Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command: refactor to remove configuration global variable #2118

Merged
merged 4 commits into from
Nov 12, 2019
Merged

Command: refactor to remove configuration global variable #2118

merged 4 commits into from
Nov 12, 2019

Conversation

brandonforster
Copy link
Contributor

Fixes #2017

Signed-off-by: Brandon Forster brandonforster@gmail.com

@brandonforster brandonforster self-assigned this Nov 12, 2019
@brandonforster
#2017: Removed configuration global from core-command.
e8837ee 
Signed-off-by: Brandon Forster <brandonforster@gmail.com>
michaelestrin
michaelestrin suggested changes Nov 12, 2019
View reviewed changes
internal/core/command/init.go Outdated Show resolved Hide resolved
internal/core/command/router.go Outdated Show resolved Hide resolved
@brandonforster
#2017: Removed loggingclient and httperrorhandler
e3afee8 
Signed-off-by: Brandon Forster <brandonforster@gmail.com>
@codecov-io
Copy link

codecov-io commented Nov 12, 2019 •
edited
Loading

Codecov Report

Merging #2118 into master will increase coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2118      +/-   ##
==========================================
+ Coverage   41.76%   41.83%   +0.06%     
==========================================
  Files         184      183       -1     
  Lines       12151    12132      -19     
==========================================
  Hits         5075     5075              
+ Misses       6779     6760      -19     
  Partials      297      297
Impacted Files Coverage Δ
internal/core/command/router.go 0% <0%> (ø) ⬆️
internal/core/command/restDevice.go 0% <0%> (ø) ⬆️
cmd/core-command/main.go 0% <0%> (ø) ⬆️
internal/core/command/init.go 0% <0%> (ø) ⬆️
internal/core/command/device.go 31.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7fd3d0...2b5b3ef. Read the comment docs.

@brandonforster
#2017: Changed config to be pass by ref instead of value
cfe5ddd 
Signed-off-by: Brandon Forster <brandonforster@gmail.com>
michaelestrin
michaelestrin approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@michaelestrin michaelestrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending successful builds.

@brandonforster brandonforster merged commit 7aeef72 into edgexfoundry:master Nov 12, 2019
@brandonforster brandonforster deleted the issue_2017 branch November 12, 2019 22:21
@brandonforster brandonforster added this to the EdgeX Geneva milestone Nov 19, 2019
@brandonforster brandonforster mentioned this pull request Nov 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelestrin michaelestrin michaelestrin approved these changes

Assignees

@brandonforster brandonforster

Labels
geneva
Projects
None yet
Milestone
EdgeX Geneva
Development

Successfully merging this pull request may close these issues.

Command: refactor to remove Configuration global variable
3 participants
@brandonforster @codecov-io @michaelestrin