feat: Add device last connected metrics #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes edgexfoundry#1470. Add device last connected metrics to Get/Set command. Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
cloudxxx8
reviewed
Sep 20, 2023
There was a problem hiding this comment.
Use URL escape for device name if configuration.Service.EnableNameFieldEscape is true
Reference:
https://github.com/edgexfoundry/device-sdk-go/pull/1502/files
https://github.com/edgexfoundry/device-sdk-go/pull/1506/files
cloudxxx8
reviewed
Sep 20, 2023
- Register/Unregister LastConnected on add/remove device cache. - Update LastConnected for async reading Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
lindseysimple
force-pushed
the
issue-1470
branch
from
352f41d
to
af69577
Compare
|
Change's made for |
lenny-goodell
requested changes
Sep 20, 2023
Add unit tests for new lastConnected methods in deviceCache. Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
lenny-goodell
requested changes
Sep 26, 2023
internal/cache/devices.go
Outdated
| registeredName := strings.Replace(lastConnectedPrefix, deviceNameText, deviceName, 1) | ||
|
|
||
| err := metricsManager.Register(registeredName, metric, map[string]string{"device": deviceName}) | ||
| err := metricsManager.Register(registeredName, metric, nil) |
There was a problem hiding this comment.
The tag is still needed. This allows for filtering on a dashboard such as Grafana.
There was a problem hiding this comment.
Done, tag added back. Thanks.
Add back the device tag to the LastConnected metric. Signed-off-by: Lindsey Cheng <beckysocute@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1470. Add device last connected metrics to Get/Set command.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)