-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement URI for Profile, Device, & Provision Watcher #1471
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1471 +/- ##
==========================================
- Coverage 47.68% 46.82% -0.86%
==========================================
Files 26 30 +4
Lines 2479 2800 +321
==========================================
+ Hits 1182 1311 +129
- Misses 1214 1390 +176
- Partials 83 99 +16
|
a84177b
to
2c47d96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed just the Devices code and tests. There are changes that will also apply to Profiles and ProvisionWatcher. I will review those once all the changes just have been applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got through device and profiles
Closes edgexfoundry#1467 Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
…nction Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Non-Secure testing
** Secure testing**
New Dependency Instructions (If applicable)