Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement URI for Profile, Device, & Provision Watcher #1471

Merged
merged 9 commits into from
Jul 19, 2023

Conversation

ejlee3
Copy link
Contributor

@ejlee3 ejlee3 commented Jul 7, 2023

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Non-Secure testing

  1. pull the latest code and build device simple
  2. run the non-secure edgex stack
  3. run device-simple with its standard configuration
  4. stop device-simple
  5. modify the configuration to point to a custom index.json file (created in internal/uri-test-files/*/index.json)
  6. run device-simple and ensure that the index.json works without errors

** Secure testing**

  1. create a private repo
  2. run the secure edgex stack
  3. use both configuration options - file and URI
  4. run and ensure device-simple works

New Dependency Instructions (If applicable)

internal/provision/provisionwatchers.go Outdated Show resolved Hide resolved
internal/provision/provisionwatchers.go Outdated Show resolved Hide resolved
internal/provision/provisionwatchers.go Outdated Show resolved Hide resolved
internal/provision/provisionwatchers.go Outdated Show resolved Hide resolved
internal/provision/provisionwatchers.go Outdated Show resolved Hide resolved
internal/provision/provisionwatchers.go Outdated Show resolved Hide resolved
internal/provision/provisionwatchers.go Outdated Show resolved Hide resolved
internal/provision/provisionwatchers.go Outdated Show resolved Hide resolved
internal/provision/provisionwatchers.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #1471 (413a271) into main (d74039b) will decrease coverage by 0.86%.
The diff coverage is 45.74%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1471      +/-   ##
==========================================
- Coverage   47.68%   46.82%   -0.86%     
==========================================
  Files          26       30       +4     
  Lines        2479     2800     +321     
==========================================
+ Hits         1182     1311     +129     
- Misses       1214     1390     +176     
- Partials       83       99      +16     
Files Changed Coverage Δ
internal/provision/provisionwatchers.go 34.78% <38.55%> (ø)
internal/provision/devices.go 36.11% <44.31%> (ø)
internal/provision/profiles.go 43.00% <47.77%> (ø)
internal/provision/common.go 71.42% <71.42%> (ø)

@ejlee3 ejlee3 force-pushed the uri4files branch 6 times, most recently from a84177b to 2c47d96 Compare July 18, 2023 01:14
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed just the Devices code and tests. There are changes that will also apply to Profiles and ProvisionWatcher. I will review those once all the changes just have been applied.

internal/provision/devices.go Outdated Show resolved Hide resolved
internal/provision/devices.go Outdated Show resolved Hide resolved
internal/provision/devices.go Outdated Show resolved Hide resolved
internal/provision/devices.go Outdated Show resolved Hide resolved
internal/provision/devices.go Outdated Show resolved Hide resolved
internal/provision/devices.go Outdated Show resolved Hide resolved
internal/provision/devices.go Outdated Show resolved Hide resolved
internal/provision/devices.go Outdated Show resolved Hide resolved
internal/provision/devices_test.go Outdated Show resolved Hide resolved
internal/provision/devices_test.go Outdated Show resolved Hide resolved
internal/provision/devices.go Outdated Show resolved Hide resolved
internal/provision/profiles.go Outdated Show resolved Hide resolved
internal/provision/provisionwatchers.go Outdated Show resolved Hide resolved
internal/provision/provisionwatchers.go Outdated Show resolved Hide resolved
internal/provision/provisionwatchers.go Outdated Show resolved Hide resolved
internal/provision/devices.go Outdated Show resolved Hide resolved
internal/provision/devices.go Outdated Show resolved Hide resolved
internal/provision/devices.go Outdated Show resolved Hide resolved
internal/provision/devices.go Outdated Show resolved Hide resolved
@ejlee3 ejlee3 marked this pull request as ready for review July 18, 2023 19:07
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got through device and profiles

internal/provision/profiles.go Outdated Show resolved Hide resolved
internal/provision/profiles.go Outdated Show resolved Hide resolved
internal/provision/profiles_test.go Outdated Show resolved Hide resolved
internal/provision/profiles_test.go Outdated Show resolved Hide resolved
internal/provision/profiles_test.go Outdated Show resolved Hide resolved
internal/provision/common.go Show resolved Hide resolved
internal/provision/common.go Show resolved Hide resolved
internal/provision/profiles.go Outdated Show resolved Hide resolved
internal/provision/profiles.go Show resolved Hide resolved
internal/provision/profiles.go Outdated Show resolved Hide resolved
internal/provision/profiles.go Show resolved Hide resolved
internal/provision/profiles.go Outdated Show resolved Hide resolved
internal/provision/profiles.go Outdated Show resolved Hide resolved
Closes edgexfoundry#1467

Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
…nction

Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
@lenny-goodell lenny-goodell merged commit 0776c05 into edgexfoundry:main Jul 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants