-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add resource, command, and device tags to reading/event #1297
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1297 +/- ##
==========================================
+ Coverage 50.91% 51.31% +0.40%
==========================================
Files 27 27
Lines 2406 2426 +20
==========================================
+ Hits 1225 1245 +20
Misses 1075 1075
Partials 106 106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just need to add missing unit tests
f710fef
to
6ccb044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@FelixTing please resolve the conflict |
rebased |
@FelixTing please make sure the unit test can be passed |
1. Add device resource tags to reading 2. Add device command tags to event 3. Add device tags to event Note: Device tags take precedence over Device Command tags. Signed-off-by: Felix Ting <felix@iotechsys.com>
all unit tests have passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix #1294
Note: Device tags take precedence over Device Command tags.
Signed-off-by: Felix Ting felix@iotechsys.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
simple-device.toml
Simple-Driver.yaml
curl http://localhost:59882/api/v2/device/name/Simple-Device01/Switch
Verify the returned event contains resource, command, and device tags.
New Dependency Instructions (If applicable)