Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade to Go 1.18 and optimize attribution script #98

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

lenny-goodell
Copy link
Member

Signed-off-by: Leonard Goodell leonard.goodell@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-rfid-llrp-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A for Build PRs
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A for Build PRs

Testing Instructions

run make build test docker

New Dependency Instructions (If applicable)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell added 3-high priority denoting release-blocking issues ci issue_type denoting non-code changes such as testing or compilation labels Jul 12, 2022
@lenny-goodell lenny-goodell added this to the Levski milestone Jul 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #98 (1d02a79) into main (a275810) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   41.08%   41.13%   +0.05%     
==========================================
  Files          21       21              
  Lines        9016     9016              
==========================================
+ Hits         3704     3709       +5     
+ Misses       4142     4139       -3     
+ Partials     1170     1168       -2     
Impacted Files Coverage Δ
internal/llrp/reader.go 41.24% <0.00%> (+1.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a275810...1d02a79. Read the comment docs.

Copy link
Member

@bill-mahoney bill-mahoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit a486f61 into edgexfoundry:main Jul 12, 2022
@lenny-goodell lenny-goodell deleted the go1.18 branch July 12, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-high priority denoting release-blocking issues ci issue_type denoting non-code changes such as testing or compilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants