Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added cors cnfiguration to service section in configuration toml #67

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

marcpfuller
Copy link
Contributor

Signed-off-by: Marc-Philippe Fuller marc-philippe.fuller@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-rfid-llrp-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) this N/A
  • I have opened a PR for the related docs change (if not, why?)N/A

Testing Instructions

  1. Build source make build
  2. Ran device service cd ./cmd && ./device-rfid-llrp
  3. Ran make test

New Dependency Instructions (If applicable)

N/A

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>
@marcpfuller marcpfuller changed the title update: added cors cnfiguration to service section in configuration toml fix: added cors cnfiguration to service section in configuration toml Mar 23, 2022
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit e0db465 into edgexfoundry:main Mar 23, 2022
@lenny-goodell lenny-goodell linked an issue Mar 28, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device LLRP: Add missing CORS configuration section
2 participants