Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(snap): Update command and metadata sourcing #532

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented Mar 16, 2023

  • Inline CLIs flags
  • Remove unused packages
  • Remove external metadata sourcing
  • Remove deprecated startup-duration and startup-interval snap options

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-service-configurable/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

- Inline CLIs flags
- Remove unused packages
- Remove external metadata sourcing

Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
@MonicaisHer
Copy link
Contributor Author

Testing this PR is currently challenging because snap testing has been disabled due to previous breaking changes.

Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
@farshidtz farshidtz merged commit 11af183 into edgexfoundry:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants