Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable security hardening #396

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

jpwhitemn
Copy link
Member

fixes: #391
Signed-off-by: jpwhitemn jpwhite_mn@yahoo.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-service-configurable/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) n/a
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) n/a
  • I have opened a PR for the related docs change (if not, why?) n/a

Testing Instructions

New Dependency Instructions (If applicable)

fixes: edgexfoundry#391
Signed-off-by: jpwhitemn <jpwhite_mn@yahoo.com>
Copy link
Collaborator

@bnevis-i bnevis-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in -buildmode=pie and -linkmode=external when CGO_ENABLED=1

Signed-off-by: jpwhitemn <jpwhite_mn@yahoo.com>
@jpwhitemn jpwhitemn requested a review from bnevis-i April 7, 2022 23:10
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit e18cf4e into edgexfoundry:main Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ASC] Security: Implement CGO binary hardening
3 participants