build(snap): source metadata from repo #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metadata kept in snapcraft.yaml is obsolete because it is being overridden on the store. This change will allow sourcing the central copy of metadata. See canonical/edgex-snap-metadata#2 Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
MonicaisHer
changed the title
13 tasks
|
@farshidtz @siggiskulason Could you please review it? Thanks! |
farshidtz
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
Thanks @MonicaisHer
Testing Instructions
# clean and build:
$ snapcraft clean && snapcraft
# unpack the built snap:
$ unsquashfs name.snap
# verify that icon exists:
$ ls squashfs-root/meta/gui/icon.png
squashfs-root/meta/gui/icon.png
# verify that version, summary and description are included
$ cat squashfs-root/meta/snap.yaml
...
version: 2.2.0-dev.12
summary: EdgeX App Service Configurable
description: |-
This service is provided as an easy way to get started with processing data flowing through EdgeX.
It leverages the App Functions SDK and provides a way for developers to use configuration instead of writing code to utilize the built-in functionalities.
**Snap usage instructions**
https://github.com/edgexfoundry/app-service-configurable/blob/main/snap/README.md
**Source code and more info**
https://github.com/edgexfoundry/app-service-configurable
**Service usage examples**
* v1.3: https://docs.edgexfoundry.org/1.3/microservices/application/AppServiceConfigurable
* v2.1: https://docs.edgexfoundry.org/2.1/microservices/application/AppServiceConfigurable
* v2.2: https://docs.edgexfoundry.org/2.2/microservices/application/AppServiceConfigurable
**EdgeX Documentation**
https://docs.edgexfoundry.org
**Reference platform snap**
https://snapcraft.io/edgexfoundry
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata kept in snapcraft.yaml is obsolete because it is being overridden on the store. This change will allow sourcing the central copy of metadata.
See canonical/edgex-snap-metadata#2
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-service-configurable/blob/main/.github/CONTRIBUTING.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)