fix: Remove retry related properties and update secret path of SecretStore config #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Store config SecretStore config no longer support Retry related properties and secret path now only needs service specific path, /v1/secret/edgex/ automatically prefix in front of it. Fixes: edgexfoundry#271 Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
jim-wang-intel
force-pushed
the
remove-retry-and-update-secret-path
branch
from
68f9408
to
0f39b46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SecretStore config no longer support Retry related properties and secret path now only needs service specific path, /v1/secret/edgex/ automatically prefix in front of it.
Fixes: #271
Signed-off-by: Jim Wang yutsung.jim.wang@intel.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Retry related properties exists and secret path is full path.
Issue Number: #271
What is the new behavior?
Retry related properties are removed and secret path is just service specific.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
Are there any specific instructions or things that should be known prior to reviewing?
Other information
In draft mode until we have tagged app-function-sdk version available for go.mod from CI pipeline.