feat: Add Registry/Config Access token capability via Secret Provider #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-standard mixed case service key name change to simplified lower case `app-<profile name>` Removed previous file based access token config settings closes edgexfoundry#222 BREAKING CHANGE: When run with the secure Edgex Stack now need to have the SecretStore configured, a Vault token created and run with EDGEX_SECURITY_SECRET_STORE=true. BREAKING CHANGE: Service key changed to `app-<profile name>` Signed-off-by: lenny <leonard.goodell@intel.com>
|
The TAF tests will need to be update for the change in service key names. Thus this PR is in draft mode until those changes can be made. |
jim-wang-intel
requested changes
Apr 7, 2021
Signed-off-by: lenny <leonard.goodell@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes
BREAKING CHANGE: When run with the secure Edgex Stack now need to have the SecretStore configured, a Vault token created and run with EDGEX_SECURITY_SECRET_STORE=true.
BREAKING CHANGE: Service key changed to
app-<profile name>Signed-off-by: lenny leonard.goodell@intel.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Registry/Config access tokens capability supported via files
Issue Number: #222
What is the new behavior?
Registry/Config access tokens capability now supported via SecretProvider
Non-standard mixed case service key name change to simplified lower case
app-<profile name>Removed previous file based access token config settings
Does this PR introduce a breaking change?
BREAKING CHANGE: When run with the secure Edgex Stack now need to have the SecretStore configured, a Vault token created and run with EDGEX_SECURITY_SECRET_STORE=true.
BREAKING CHANGE: Service key changed to
app-<profile name>Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information