Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change logging of CorrelationID to use proper function call #924

Merged

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Call CorrelationID API in log messages missing ()

Issue Number: #923

What is the new behavior?

All calls CorrelationID API now proper function calls.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

Are there any specific instructions or things that should be known prior to reviewing?

Other information

fixes edgexfoundry#923

Signed-off-by: lenny <leonard.goodell@intel.com>
@codecov-commenter
Copy link

Codecov Report

Merging #924 (e1c098b) into main (7655824) will not change coverage.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #924   +/-   ##
=======================================
  Coverage   65.33%   65.33%           
=======================================
  Files          33       33           
  Lines        2345     2345           
=======================================
  Hits         1532     1532           
  Misses        722      722           
  Partials       91       91           
Impacted Files Coverage Δ
pkg/transforms/mqttsecret.go 22.22% <0.00%> (ø)
internal/runtime/runtime.go 72.66% <100.00%> (ø)
internal/runtime/storeforward.go 55.30% <100.00%> (ø)
pkg/transforms/http.go 88.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7655824...e1c098b. Read the comment docs.

@lenny-goodell lenny-goodell merged commit 83c633e into edgexfoundry:main Jul 15, 2021
@lenny-goodell lenny-goodell deleted the fix-CorrelationID-calls branch July 15, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants