refactor: Move topic config to appropriate config struct #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 7, 2021 16:33
closes #598 Signed-off-by: lenny <leonard.goodell@intel.com>
closes #598 Signed-off-by: lenny <leonard.goodell@intel.com>
Signed-off-by: lenny <leonard.goodell@intel.com>
close edgexfoundry#829 BREAKING CHANGE: Edgex-MessageBus and External-Mqtt configuration has changed Signed-off-by: lenny <leonard.goodell@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #830 +/- ##
==========================================
+ Coverage 62.47% 62.79% +0.32%
==========================================
Files 31 31
Lines 1964 1981 +17
==========================================
+ Hits 1227 1244 +17
Misses 647 647
Partials 90 90
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Topic config at level with no context.
Issue Number: close #829
What is the new behavior?
Topic config now at level where they have context
Does this PR introduce a breaking change?
BREAKING CHANGE: Edgex-MessageBus and External-Mqtt configuration has changed
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information