Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing instructions to remove replace statement from go.mod file #818

Merged

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented May 6, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Instructions to remove replace statement missing

Issue Number: #814

What is the new behavior?

Instructions to remove replace statement now exist.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@lenny-goodell lenny-goodell changed the title fix: Add missing instruction to remove replace statement from go.mod file fix: Add missing instructions to remove replace statement from go.mod file May 6, 2021
jim-wang-intel
jim-wang-intel previously approved these changes May 7, 2021
Walt-Intel
Walt-Intel previously approved these changes May 7, 2021
Copy link
Contributor

@Walt-Intel Walt-Intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lenny-goodell
Copy link
Member Author

recheck

… file

close edgexfoundry#814

Signed-off-by: lenny <leonard.goodell@intel.com>
@codecov-commenter
Copy link

Codecov Report

Merging #818 (de4234b) into master (7ab1d82) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #818   +/-   ##
=======================================
  Coverage   63.03%   63.03%           
=======================================
  Files          31       31           
  Lines        1975     1975           
=======================================
  Hits         1245     1245           
  Misses        645      645           
  Partials       85       85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ab1d82...de4234b. Read the comment docs.

@lenny-goodell lenny-goodell merged commit caac711 into edgexfoundry:master May 7, 2021
@lenny-goodell lenny-goodell deleted the template-readme-fix branch May 7, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants