Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable Registry and Config access token #772

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Registry/Config access token not supported

Issue Number: #769

What is the new behavior?

Registry/Config access token now supported

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

close #769

Signed-off-by: lenny <leonard.goodell@intel.com>
jim-wang-intel
jim-wang-intel previously approved these changes Mar 29, 2021
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…quired.

Signed-off-by: lenny <leonard.goodell@intel.com>
@lenny-goodell
Copy link
Member Author

recheck

2 similar comments
@lenny-goodell
Copy link
Member Author

recheck

@lenny-goodell
Copy link
Member Author

recheck

@codecov-io
Copy link

Codecov Report

Merging #772 (0fe2911) into master (d683052) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #772   +/-   ##
=======================================
  Coverage   63.13%   63.13%           
=======================================
  Files          31       31           
  Lines        1972     1972           
=======================================
  Hits         1245     1245           
  Misses        642      642           
  Partials       85       85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d683052...0fe2911. Read the comment docs.

@lenny-goodell lenny-goodell merged commit 774021d into edgexfoundry:master Mar 30, 2021
@lenny-goodell lenny-goodell deleted the access-token branch March 30, 2021 15:31
@lenny-goodell lenny-goodell linked an issue Mar 30, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Secure Consul Ph2] App SDK: Enable Registry/Config access tokens
3 participants