Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add new FilterBySourceName function #731

Merged
merged 2 commits into from
Mar 4, 2021
Merged

feat: Add new FilterBySourceName function #731

merged 2 commits into from
Mar 4, 2021

Conversation

lenny-goodell
Copy link
Member

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

FilterBySourceName function doesn't exists
Event doesn't have SourceName property

Issue Number: #723

What is the new behavior?

SourceName has been added to Event and now can be used to filter Events
New FilterBySourceName function added

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

lenny added 2 commits March 4, 2021 13:54
refactor: Remove V1 API code and swagger
35b4e4d 
Also reworked V2 code to remove `v2` in paths

closes #720

BREAKING CHANGE: V1 API's no longer supported

Signed-off-by: lenny <leonard.goodell@intel.com>
feat: Add new FilterBySourceName function
7ac3b69 
SourceName has been added to Event and now can be used to filter Events

close #723

Signed-off-by: lenny <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell linked an issue Mar 4, 2021 that may be closed by this pull request
SDK: Add new FilterBySourceName function #723
Closed
jim-wang-intel
jim-wang-intel requested changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor tweaks: define a constant if shared by others

appsdk/configurable.go Show resolved Hide resolved
pkg/transforms/filter.go Show resolved Hide resolved
pkg/transforms/filter.go Show resolved Hide resolved
@lenny-goodell lenny-goodell merged commit 3ee2f0b into edgexfoundry:master Mar 4, 2021
@lenny-goodell lenny-goodell deleted the SourceName branch March 4, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexCuse AlexCuse AlexCuse approved these changes

@jim-wang-intel jim-wang-intel jim-wang-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK: Add new FilterBySourceName function
3 participants
@lenny-goodell @AlexCuse @jim-wang-intel