-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove MarkAsPushed feature #607
feat: Remove MarkAsPushed feature #607
Conversation
08a139a
to
f281f6f
Compare
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
==========================================
- Coverage 61.62% 60.86% -0.77%
==========================================
Files 30 30
Lines 1798 1763 -35
==========================================
- Hits 1108 1073 -35
Misses 618 618
Partials 72 72
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to make dure docs and examples are updated to remove this stuff
f281f6f
to
ce4b293
Compare
Yup, I have created issues for those updates. |
closes #594 Signed-off-by: lenny <leonard.goodell@intel.com>
ce4b293
to
16fd758
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
MarkAsPush feature exists in SDK
Issue Number: #594
What is the new behavior?
MarkAsPush feature no longer exists in SDK
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information