Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove MarkAsPushed feature #607

Merged

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

MarkAsPush feature exists in SDK

Issue Number: #594

What is the new behavior?

MarkAsPush feature no longer exists in SDK

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@codecov-io
Copy link

codecov-io commented Dec 17, 2020

Codecov Report

Merging #607 (481aa38) into master (2bc84c3) will decrease coverage by 0.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
- Coverage   61.62%   60.86%   -0.77%     
==========================================
  Files          30       30              
  Lines        1798     1763      -35     
==========================================
- Hits         1108     1073      -35     
  Misses        618      618              
  Partials       72       72              
Impacted Files Coverage Δ
appcontext/context.go 73.07% <ø> (-6.93%) ⬇️
appsdk/configurable.go 54.07% <ø> (-0.34%) ⬇️
internal/runtime/runtime.go 70.12% <ø> (-1.48%) ⬇️
internal/runtime/storeforward.go 54.47% <ø> (-1.44%) ⬇️
internal/store/db/redis/models/storedobject.go 96.82% <ø> (-0.51%) ⬇️
pkg/transforms/coredata.go 72.72% <ø> (-7.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bc84c3...481aa38. Read the comment docs.

rsdmike
rsdmike previously approved these changes Dec 17, 2020
Copy link
Member

@rsdmike rsdmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to make dure docs and examples are updated to remove this stuff

@lenny-goodell
Copy link
Member Author

We'll need to make sure docs and examples are updated to remove this stuff

Yup, I have created issues for those updates.

closes #594

Signed-off-by: lenny <leonard.goodell@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove MarkAsPush feature (APP SDK)
4 participants