Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove deprecated MQTTSend pipeline function #592

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Deprecated MQTTSend pipeline function exists in code

Issue Number: #547

What is the new behavior?

Deprecated MQTTSend pipeline function code has been removed

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@codecov-io
Copy link

codecov-io commented Dec 9, 2020

Codecov Report

Merging #592 (6f61144) into master (d5e638f) will increase coverage by 1.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
+ Coverage   60.50%   62.49%   +1.98%     
==========================================
  Files          41       40       -1     
  Lines        2175     2061     -114     
==========================================
- Hits         1316     1288      -28     
+ Misses        772      692      -80     
+ Partials       87       81       -6     
Impacted Files Coverage Δ
appsdk/configurable.go 54.41% <ø> (+0.37%) ⬆️
appsdk/sdk.go 34.80% <ø> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e638f...6f61144. Read the comment docs.

closes #547

Signed-off-by: lenny <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell changed the title feat(MQTTSend): Remove deprecated MQTTSend pipeline function feat: Remove deprecated MQTTSend pipeline function Dec 10, 2020
@lenny-goodell lenny-goodell merged commit c9ed7d5 into edgexfoundry:master Dec 10, 2020
@lenny-goodell lenny-goodell deleted the remove-MQTTSend branch December 10, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants