refactor: Change all unit tests to use logger.NewMockCient() #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so test.log files are no longer created and the test results are not cluttered with log messages. closes #477 Signed-off-by: lenny <leonard.goodell@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
==========================================
- Coverage 64.65% 60.97% -3.69%
==========================================
Files 35 42 +7
Lines 2105 2196 +91
==========================================
- Hits 1361 1339 -22
- Misses 663 770 +107
- Partials 81 87 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
File logging is used and causes unneeded local log files to be created.
Test results are not cluttered with log messages.
Issue Number: #477
What is the new behavior?
Mock Logger doesn't log anything, so test results are no longer cluttered with log messages.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
No
Are there any specific instructions or things that should be known prior to reviewing?
Other information