Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade to Go 1.18 and alpine 3.16 #1146

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

lenny-goodell
Copy link
Member

address #1145 for SDK

Signed-off-by: Leonard Goodell leonard.goodell@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) N/A
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

New Dependency Instructions (If applicable)

jim-wang-intel
jim-wang-intel previously approved these changes Jul 6, 2022
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

jim-wang-intel
jim-wang-intel previously approved these changes Jul 6, 2022
@lenny-goodell lenny-goodell linked an issue Jul 6, 2022 that may be closed by this pull request
3 tasks
address edgexfoundry#1145 for SDK

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell marked this pull request as ready for review July 11, 2022 16:26
@lenny-goodell
Copy link
Member Author

recheck

1 similar comment
@lenny-goodell
Copy link
Member Author

recheck

@codecov-commenter
Copy link

Codecov Report

Merging #1146 (229abc3) into main (3a3cae1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1146   +/-   ##
=======================================
  Coverage   67.95%   67.95%           
=======================================
  Files          37       37           
  Lines        3099     3099           
=======================================
  Hits         2106     2106           
  Misses        860      860           
  Partials      133      133           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a3cae1...229abc3. Read the comment docs.

@lenny-goodell lenny-goodell merged commit 4a1eef6 into edgexfoundry:main Jul 11, 2022
@lenny-goodell lenny-goodell deleted the go1.18 branch July 11, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go 1.18 Upgrade
4 participants