Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(triggers): Write HTTP Response Data #1034

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

AlexCuse
Copy link
Contributor

After refactoring response data was not written to response

fixes #1028

Signed-off-by: Alex Ullrich alex.ullrich@gmail.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
    unit tests sufficient
  • I have opened a PR for the related docs change (if not, why?)
    no docs change

Testing Instructions

New Dependency Instructions (If applicable)

After refactoring response data was not written to response

fixes edgexfoundry#1028

Signed-off-by: Alex Ullrich <alex.ullrich@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1034 (77d5a7b) into main (b262707) will decrease coverage by 0.07%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1034      +/-   ##
==========================================
- Coverage   68.97%   68.90%   -0.08%     
==========================================
  Files          36       36              
  Lines        2856     2865       +9     
==========================================
+ Hits         1970     1974       +4     
- Misses        777      780       +3     
- Partials      109      111       +2     
Impacted Files Coverage Δ
internal/trigger/http/rest.go 88.13% <44.44%> (-7.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b262707...77d5a7b. Read the comment docs.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 7f6b5c5 into edgexfoundry:main Jan 27, 2022
FelixTing pushed a commit to FelixTing/app-functions-sdk-go that referenced this pull request Mar 3, 2022
After refactoring response data was not written to response

fixes edgexfoundry#1028

Signed-off-by: Alex Ullrich <alex.ullrich@gmail.com>

Co-authored-by: Lenny Goodell <leonard.goodell@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No response body when trigger pipeline with matching device name
3 participants