Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update to latest go-mod-messaging w/o ZMQ on windows #1009

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

lenny-goodell
Copy link
Member

BREAKING CHANGE: ZeroMQ no longer supported on native Windows for EdgeX
MessageBus

Signed-off-by: Leonard Goodell leonard.goodell@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A for Build PR
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) N/A for Build PR
  • I have opened a PR for the related docs change (if not, why?) N/A for Build PR

Testing Instructions

N/A for Build PR

New Dependency Instructions (If applicable)

N/A for Build PR

BREAKING CHANGE: ZeroMQ no longer supported on native Windows for EdgeX
MessageBus

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit d30acd6 into edgexfoundry:main Nov 29, 2021
@lenny-goodell lenny-goodell deleted the no-win-zmq branch November 29, 2021 21:26
FelixTing pushed a commit to FelixTing/app-functions-sdk-go that referenced this pull request Mar 3, 2022
…ndry#1009)

BREAKING CHANGE: ZeroMQ no longer supported on native Windows for EdgeX
MessageBus

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants