Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/local latlon grid #101

Merged
merged 14 commits into from
Feb 1, 2024
Merged

Feature/local latlon grid #101

merged 14 commits into from
Feb 1, 2024

Conversation

mathleur
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 195 lines in your changes are missing coverage. Please review.

Comparison is base (73e183f) 89.12% compared to head (facc193) 89.90%.
Report is 5 commits behind head on develop.

Files Patch % Lines
...ormations/datacube_mappers/mapper_types/healpix.py 63.26% 36 Missing ⚠️
polytope/datacube/backends/fdb.py 0.00% 35 Missing ⚠️
...ormations/datacube_cyclic/cyclic_axis_decorator.py 79.10% 28 Missing ⚠️
...rmations/datacube_mappers/mapper_axis_decorator.py 69.41% 26 Missing ⚠️
...ormations/datacube_merger/merger_axis_decorator.py 74.19% 16 Missing ⚠️
...datacube_type_change/type_change_axis_decorator.py 76.66% 14 Missing ⚠️
...mations/datacube_reverse/reverse_axis_decorator.py 75.00% 12 Missing ⚠️
tests/test_local_regular_grid.py 42.85% 12 Missing ⚠️
...ansformations/datacube_mappers/datacube_mappers.py 84.90% 8 Missing ⚠️
polytope/datacube/index_tree.py 54.54% 5 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
+ Coverage    89.12%   89.90%   +0.78%     
===========================================
  Files           73       80       +7     
  Lines         7004     6935      -69     
===========================================
- Hits          6242     6235       -7     
+ Misses         762      700      -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"resolution": [80, 80],
"axes": ["latitude", "longitude"],
"local": [-40, 40, -20, 60],
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, here we are assuming the local grid's first point is aligned with the bounds we put here. This might not always be the case, if the local grid was created by cropping a global grid.

image

When we have some real grids to try we might need to change this behaviour.

@mathleur mathleur merged commit f4573ac into develop Feb 1, 2024
6 checks passed
@mathleur mathleur deleted the feature/local_latlon_grid branch February 1, 2024 14:05
@mathleur mathleur restored the feature/local_latlon_grid branch February 5, 2024 09:22
@mathleur mathleur deleted the feature/local_latlon_grid branch February 5, 2024 11:09
@mathleur mathleur restored the feature/local_latlon_grid branch February 5, 2024 11:13
@mathleur mathleur deleted the feature/local_latlon_grid branch February 5, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants