-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload fails with an Internal Server Error #343
Comments
@mbarbero could you look into the logs? Do you need a more precise timestamp? |
Yes, more precise timestamp will be required here. Thanks! Also, if |
It has a |
Right, Here is a full response with a timestamp:
|
Could the issue possibly be an enormous load spike on the Open VSX Registry due to the release of OpenVSCode Server? I believe they hook to the registry in all their instances by default. Or have you determined that it's not load related and localized to just this update? Or is it an issue with all/many updates? |
@mbarbero could you look up the logs at the timestamp given above? |
@toddewilliams, it's unlikely. There has been dozen of new versions being published during the week, and we only got this report. @spoenemann, @wgalanciak application logs from Sept 29th are gone. Would you mind re-trying and giving me a new response with timestamp? Thanks! |
Sure, here it is:
|
openvsx logs are very verbose and plagued with some error from #345. It means logs from yesterday are already almost already gone and I cannot find anything at the given timestamp. It seems that we're not in the same timezone. Could we schedule the test so that I can have a look at the logs in a timely manner? I'm in CEST. Thanks! |
Please let me know if 9:00 am CEST next Monday (11.10) is fine for you. |
LGTM. Thanks! |
As planned, I have tried to upload twice using two different tokens (a new one and one from 1 year ago):
|
Thank you! @spoenemann , it seems that one of the column has a VARCHAR(2048) type that is not validated at the API level.
|
Ok thanks! This seems to be a side-effect of #264. The field size violation can be from the To Do:
@amvanbaren could you take over and address these topics? |
The size violation could also be from the |
Checking the package.json that we are uploading, we have a minimal
If at all helpful for debugging, the VSIX we are trying to upload can also be accessed from https://www.codetogether.com/download/vscode/ Any help on this would be superb as we have customers impacted who rely on OpenVSX. Thanks kindly! |
@TimWebb I tried publishing codetogether. It failed on this statement: binding parameter [1] as [BOOLEAN] - [true] @spoenemann The tags parameter contains 3234 chars. The The standard text analyzer in ElasticSearch converts text to lowercase. I can make tags case insensitive in the server to remove duplicates. Another solution is to increase the tags column size to 4096. What do you think is the best course of action? |
Oh I see. the difference in the Maybe we should revert the fetching of tags to the previous version: extension.setTags(getStringList(packageJson.path("keywords"))); and additionally increase the column size to be sure? |
Yes, the change was introduced in getMetadata()
By adding languages to tags you can search for e.g. Java and find all extensions that support the language. Although most extensions will probably mention this in If we do revert back to the previous version, then all extension versions need to be re-processed. The easy but inaccurate solution would be to take the first 5 tags for every already published extension version.
The keywords array is limited to 5 items (extension manifest). |
@spoenemann @amvanbaren In general we should use the info in |
Good point. I'll query the ms marketplace to see what tags it returns. |
@jeanp413 @spoenemann It looks like the ms marketplace only keeps the first occurance of a tag. Comparison between tags is case insensitive, but the case of the first occurance is preserved in the resulting tags list. |
Just wanted to say thank you all for the fix. As it turns out it's quite timely as we're shipping CodeTogether 5.0 today and will be testing the fix by uploading the extension quite soon. |
As Todd mentions, appreciated! @amvanbaren Do you know what the timeline may look like for this being released to production? We release CodeTogether 5 yesterday and OpenVSX users continue to be stuck back on version 4.1. Thanks kindly and have a nice weekend! |
Since Thursday, September 22nd, we have not been able to upload a new version of our extension (https://open-vsx.org/extension/genuitecllc/codetogether) to the registry.
We have tried several times over the last few days but still no luck. We also tried to create a new token but the result is the same.
Here is the whole output from the command execution:
❌ Internal Server Error
See the documentation for more information:
https://github.com/eclipse/openvsx/wiki/Publishing-Extensions
The text was updated successfully, but these errors were encountered: