-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If there is a # in the path to the Theia app, no VS Code extensions load #12064
Comments
I cannot even build Theia from the sources when there is # in the path to the local git repo nodejs/node-gyp#2556 Workaround update for the build:
Update 2:
|
To sum up, there are three separate issues:
It seems to be a webpack problem, and maybe the Theia webpack generator does not handle
If I am in this folder:
and start Theia with this command:
the local plugin folder resolution will fail:
The problem was correctly pointed out by @r3inbowari here: arduino/arduino-ide#1124 (comment) After manually modifying the
The
Actual:
Expected:
If I use any online URL decoder, it works.
The easiest way to reproduce the third issue is to modify the plugins folder inside the Theia repo and start the electron app, for example, from the sources: When I am on 73f32f7, the following change is sufficient to trigger the bug: diff --git a/.gitignore b/.gitignore
index 8fcd5853d..74142fcc0 100644
--- a/.gitignore
+++ b/.gitignore
@@ -22,7 +22,7 @@ package-backup.json
.history
.Trash-*
packages/plugin/typedoc
-plugins
+plugins*
gh-pages
.vscode/ipch
dev-packages/electron/compile_commands.json
diff --git a/package.json b/package.json
index 3fcfc46ca..752b2b6da 100644
--- a/package.json
+++ b/package.json
@@ -96,7 +96,7 @@
"examples/*",
"packages/*"
],
- "theiaPluginsDir": "plugins",
+ "theiaPluginsDir": "plugins #",
"theiaPlugins": {
"eclipse-theia.builtin-extension-pack": "https://open-vsx.org/api/eclipse-theia/builtin-extension-pack/1.50.1/file/eclipse-theia.builtin-extension-pack-1.50.1.vsix",
"vscode.theme-abyss": "https://open-vsx.org/api/vscode/theme-abyss/1.62.3/file/vscode.theme-abyss-1.62.3.vsix", |
It's not possible to provide a workaround downstream with DI because the implementations are not bound: theia/packages/plugin-ext/src/main/node/plugin-ext-backend-module.ts Lines 57 to 59 in 73f32f7
|
@kittaakos , it would be possible to work around it downstream, if you would like to do so while awaiting an upstream fix, using a combination of extensions and contributions filters: create a contribution filter that removes the malfunctioning resolver, then bind Although that may fail if the classes that use the |
Thank you so much for the hint, @colin-grant-work. I will try it, and if it works downstream, I will share the temp workaround. |
Even if that doesn't work directly, because it looks like
Says const foundPluginResolver = this.pluginResolvers.find(pluginResolver => !(pluginResolver instanceof BadResolver) && pluginResolver.accept(pluginId)); would also work. |
Closes eclipse-theia/theia#12064 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Closes #1815 Ref eclipse-theia/theia#12064 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
It is. I appreciate your pointer, @colin-grant-work. Here is a hack that works in a bundled Theia app. |
Closes #1815 Ref eclipse-theia/theia#12064 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Bug Description:
Steps to Reproduce:
#
in the path. For example,/Users/a.kitta/Desktop/with #
index.js
file.As the final step, remove the
#
from the path to Theia and start it. Now, the extensions load, and there is syntax coloring.Downstream issue: arduino/arduino-ide#1124
Additional Information
The text was updated successfully, but these errors were encountered: