Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #482 add asciinema recordings #738

Conversation

mossmaurice
Copy link
Contributor

@mossmaurice mossmaurice commented Apr 15, 2021

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Branch follows the naming format (iox-#123-this-is-a-branch)
  4. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  5. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  6. Relevant issues are linked
  7. Add sensible notes for the reviewer
  8. All checks have passed (except task-list-completed)
  9. Assign PR to reviewer

Notes for Reviewer

  • Add asciinema recordings
  • Fix minor issues and add remarks in examples

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice added the documentation Improvements or additions to documentation label Apr 15, 2021
@mossmaurice mossmaurice self-assigned this Apr 15, 2021
@mossmaurice mossmaurice linked an issue Apr 15, 2021 that may be closed by this pull request
24 tasks
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #738 (9a8058a) into release_1.0 (4ba77c5) will increase coverage by 0.73%.
The diff coverage is 88.61%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release_1.0     #738      +/-   ##
===============================================
+ Coverage        73.87%   74.61%   +0.73%     
===============================================
  Files              318      318              
  Lines            11077    11309     +232     
  Branches          1950     1976      +26     
===============================================
+ Hits              8183     8438     +255     
+ Misses            2130     2096      -34     
- Partials           764      775      +11     
Flag Coverage Δ
unittests 74.56% <88.61%> (+0.74%) ⬆️
unittests_timing 30.97% <23.48%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ude/iceoryx_binding_c/internal/cpp2c_publisher.hpp 100.00% <ø> (ø)
...de/iceoryx_binding_c/internal/cpp2c_subscriber.hpp 100.00% <ø> (ø)
iceoryx_binding_c/source/c_runtime.cpp 52.94% <0.00%> (-7.06%) ⬇️
...nclude/iceoryx_dds/internal/gateway/dds_to_iox.inl 51.35% <0.00%> (ø)
...nclude/iceoryx_dds/internal/gateway/iox_to_dds.inl 62.96% <0.00%> (ø)
...ude/iceoryx_posh/internal/mepoo/memory_manager.hpp 100.00% <ø> (ø)
...clude/iceoryx_posh/internal/mepoo/shared_chunk.hpp 100.00% <ø> (ø)
...nternal/popo/building_blocks/chunk_distributor.hpp 100.00% <ø> (ø)
...ternal/popo/building_blocks/chunk_queue_popper.hpp 100.00% <ø> (ø)
...ernal/popo/building_blocks/chunk_receiver_data.inl 100.00% <ø> (ø)
... and 142 more

@elBoberido
Copy link
Member

@mossmaurice btw, if you do a rebase on release_1.0 it will be easier afterwards to bring this to master

@mossmaurice mossmaurice merged commit 8fd54b6 into eclipse-iceoryx:release_1.0 Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend documentation for 1.0 release and website
3 participants