Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#482 three pillars for website #735

Merged
merged 4 commits into from
Apr 15, 2021

Conversation

budrus
Copy link
Contributor

@budrus budrus commented Apr 15, 2021

Signed-off-by: Michael Poehnl michael.poehnl@apex.ai

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Branch follows the naming format (iox-#123-this-is-a-branch)
  4. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  5. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  6. Relevant issues are linked
  7. Add sensible notes for the reviewer
  8. All checks have passed (except task-list-completed)
  9. Assign PR to reviewer

Notes for Reviewer

Introduction of the three pillars for the start page and the "what is iceorxy" page

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

  • Closes TBD

Signed-off-by: Michael Poehnl <michael.poehnl@apex.ai>
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #735 (4a6bb95) into release_1.0 (3276b53) will decrease coverage by 0.60%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release_1.0     #735      +/-   ##
===============================================
- Coverage        74.60%   74.00%   -0.61%     
===============================================
  Files              317      319       +2     
  Lines            11259    11426     +167     
  Branches          1966     1972       +6     
===============================================
+ Hits              8400     8456      +56     
- Misses            2090     2195     +105     
- Partials           769      775       +6     
Flag Coverage Δ
unittests 73.96% <ø> (-0.60%) ⬇️
unittests_timing 30.50% <ø> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nclude/iceoryx_dds/internal/gateway/iox_to_dds.inl 55.73% <0.00%> (-7.23%) ⬇️
...nclude/iceoryx_dds/internal/gateway/dds_to_iox.inl 44.18% <0.00%> (-7.17%) ⬇️
...dds/source/iceoryx_dds/dds/cyclone_data_reader.cpp 21.78% <0.00%> (-6.62%) ⬇️
iceoryx_utils/source/concurrent/loffli.cpp 79.41% <0.00%> (-5.89%) ⬇️
iceoryx_binding_c/source/c_listener.cpp 78.57% <0.00%> (-2.20%) ⬇️
iceoryx_binding_c/source/c_publisher.cpp 81.25% <0.00%> (-1.61%) ⬇️
...sh/include/iceoryx_posh/internal/popo/wait_set.inl 91.17% <0.00%> (-1.61%) ⬇️
iceoryx_posh/source/roudi/roudi.cpp 54.28% <0.00%> (-1.60%) ⬇️
iceoryx_binding_c/source/c_wait_set.cpp 87.50% <0.00%> (-0.88%) ⬇️
...ude/iceoryx_posh/internal/popo/used_chunk_list.inl 97.82% <0.00%> (-0.33%) ⬇️
... and 46 more

Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
dkroenke
dkroenke previously approved these changes Apr 15, 2021
@mossmaurice mossmaurice added the documentation Improvements or additions to documentation label Apr 15, 2021
@mossmaurice mossmaurice linked an issue Apr 15, 2021 that may be closed by this pull request
24 tasks
CHANGELOG.md Outdated Show resolved Hide resolved
doc/website/getting-started/what-is-iceoryx.md Outdated Show resolved Hide resolved
doc/website/getting-started/what-is-iceoryx.md Outdated Show resolved Hide resolved
doc/website/getting-started/what-is-iceoryx.md Outdated Show resolved Hide resolved
doc/website/getting-started/what-is-iceoryx.md Outdated Show resolved Hide resolved
doc/website/getting-started/what-is-iceoryx.md Outdated Show resolved Hide resolved
doc/website/getting-started/what-is-iceoryx.md Outdated Show resolved Hide resolved
@budrus budrus merged commit 2921d44 into eclipse-iceoryx:release_1.0 Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend documentation for 1.0 release and website
3 participants