Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #482 add example for complex data types #716

Conversation

FerdinandSpitzschnueffler
Copy link
Contributor

@FerdinandSpitzschnueffler FerdinandSpitzschnueffler commented Apr 13, 2021

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Branch follows the naming format (iox-#123-this-is-a-branch)
  4. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  5. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  6. Relevant issues are linked
  7. Add sensible notes for the reviewer
  8. All checks have passed (except task-list-completed)
  9. Assign PR to reviewer

Notes for Reviewer

This PR introduces an example for sending/receiving our cxx constructs. The README.md includes only the outline and will be finished once the example code is approved.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #716 (a21e6b1) into master (4ce5310) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
- Coverage   74.03%   74.01%   -0.02%     
==========================================
  Files         319      319              
  Lines       11426    11458      +32     
  Branches     1972     1976       +4     
==========================================
+ Hits         8459     8481      +22     
- Misses       2192     2198       +6     
- Partials      775      779       +4     
Flag Coverage Δ
unittests 72.82% <100.00%> (-0.01%) ⬇️
unittests_timing 30.44% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ceoryx_utils/include/iceoryx_utils/cxx/variant.hpp 100.00% <ø> (ø)
...ils/include/iceoryx_utils/internal/cxx/variant.inl 96.84% <100.00%> (ø)
...e/iceoryx_utils/internal/concurrent/smart_lock.inl 92.45% <0.00%> (-7.55%) ⬇️
..._utils/source/posix_wrapper/unix_domain_socket.cpp 57.07% <0.00%> (-1.83%) ⬇️
...nclude/iceoryx_utils/internal/cxx/forward_list.inl 88.26% <0.00%> (-0.78%) ⬇️
...nternal/roudi/introspection/port_introspection.inl 71.89% <0.00%> (-0.73%) ⬇️
..._utils/include/iceoryx_utils/internal/cxx/list.inl 89.35% <0.00%> (-0.69%) ⬇️
iceoryx_posh/source/roudi/roudi.cpp 54.28% <0.00%> (ø)
...ils/include/iceoryx_utils/internal/cxx/smart_c.inl 89.06% <0.00%> (ø)
...e/iceoryx_utils/internal/concurrent/smart_lock.hpp 100.00% <0.00%> (ø)
... and 2 more

elfenpiff
elfenpiff previously approved these changes Apr 13, 2021
iceoryx_examples/complexdata/iox_publisher_vector.cpp Outdated Show resolved Hide resolved
@mossmaurice mossmaurice added the documentation Improvements or additions to documentation label Apr 13, 2021
@mossmaurice mossmaurice linked an issue Apr 13, 2021 that may be closed by this pull request
24 tasks
@budrus budrus changed the base branch from release_1.0 to master April 15, 2021 18:07
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler added the example providing example for a specific feature label Apr 15, 2021
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
…riant::index() to

uint64_t

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
…g, decrease

frequency

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
…ription

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler force-pushed the iox-#482-add-example-for-complex-data-types branch from 3ea9f27 to d7d3ba9 Compare April 20, 2021 09:33
…lkthrough for

vector example, add example to website and build script

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Copy link
Member

@dkroenke dkroenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nitpick from my side.

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
@dkroenke dkroenke self-requested a review April 27, 2021 17:15
dkroenke
dkroenke previously approved these changes Apr 27, 2021
iceoryx_examples/complexdata/README.md Outdated Show resolved Hide resolved
iceoryx_examples/complexdata/README.md Outdated Show resolved Hide resolved
iceoryx_examples/complexdata/README.md Outdated Show resolved Hide resolved
…e readme

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
elBoberido
elBoberido previously approved these changes Apr 28, 2021
MatthiasKillat
MatthiasKillat previously approved these changes Apr 28, 2021
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler merged commit 13b5fd3 into eclipse-iceoryx:master Apr 29, 2021
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler deleted the iox-#482-add-example-for-complex-data-types branch January 21, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation example providing example for a specific feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation and website for v2.0 Extend documentation for 1.0 release and website
6 participants