-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #482 add example for complex data types #716
Merged
FerdinandSpitzschnueffler
merged 16 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#482-add-example-for-complex-data-types
Apr 29, 2021
Merged
Iox #482 add example for complex data types #716
FerdinandSpitzschnueffler
merged 16 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#482-add-example-for-complex-data-types
Apr 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FerdinandSpitzschnueffler
requested review from
mossmaurice,
elfenpiff and
elBoberido
April 13, 2021 07:31
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
==========================================
- Coverage 74.03% 74.01% -0.02%
==========================================
Files 319 319
Lines 11426 11458 +32
Branches 1972 1976 +4
==========================================
+ Hits 8459 8481 +22
- Misses 2192 2198 +6
- Partials 775 779 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
elfenpiff
previously approved these changes
Apr 13, 2021
24 tasks
elBoberido
reviewed
Apr 13, 2021
FerdinandSpitzschnueffler
added
the
example
providing example for a specific feature
label
Apr 15, 2021
elBoberido
reviewed
Apr 19, 2021
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
…riant::index() to uint64_t Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
…g, decrease frequency Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
…ription Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler
force-pushed
the
iox-#482-add-example-for-complex-data-types
branch
from
April 20, 2021 09:33
3ea9f27
to
d7d3ba9
Compare
…lkthrough for vector example, add example to website and build script Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler
force-pushed
the
iox-#482-add-example-for-complex-data-types
branch
from
April 23, 2021 09:54
a5477c9
to
a8d8f25
Compare
FerdinandSpitzschnueffler
requested review from
elfenpiff,
elBoberido and
MatthiasKillat
April 23, 2021 10:24
dkroenke
reviewed
Apr 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a nitpick from my side.
iceoryx_integrationtest/iceoryx_integrationtest/test_complexdata_example.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
dkroenke
previously approved these changes
Apr 27, 2021
elBoberido
reviewed
Apr 27, 2021
MatthiasKillat
previously approved these changes
Apr 28, 2021
iceoryx_integrationtest/iceoryx_integrationtest/test_complexdata_example.py
Show resolved
Hide resolved
…e readme Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler
dismissed stale reviews from MatthiasKillat and dkroenke
via
April 28, 2021 18:28
bbe90ef
elBoberido
previously approved these changes
Apr 28, 2021
MatthiasKillat
previously approved these changes
Apr 28, 2021
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice
dismissed stale reviews from MatthiasKillat and elBoberido
via
April 29, 2021 08:47
a21e6b1
MatthiasKillat
approved these changes
Apr 29, 2021
dkroenke
approved these changes
Apr 29, 2021
FerdinandSpitzschnueffler
deleted the
iox-#482-add-example-for-complex-data-types
branch
January 21, 2022 12:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
example
providing example for a specific feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
This PR introduces an example for sending/receiving our cxx constructs. The README.md includes only the outline and will be finished once the example code is approved.
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References