-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #615 unblock app shutdown with blocked publisher #708
Iox #615 unblock app shutdown with blocked publisher #708
Conversation
…process shutdown preparation request Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
…down there are blocking publisher Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
… unblocks a blocked publisher Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 74.50% 74.52% +0.01%
==========================================
Files 315 315
Lines 11213 11253 +40
Branches 1969 1975 +6
==========================================
+ Hits 8354 8386 +32
- Misses 2083 2088 +5
- Partials 776 779 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
IpcMessage receiveBuffer; | ||
|
||
if (m_ipcChannelInterface.sendRequestToRouDi(sendBuffer, receiveBuffer) | ||
&& (1U == receiveBuffer.getNumberOfElements())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uuuhh Yoda notation you use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c&p I used :)
ASSERT_TRUE(publisher.isOffered()); | ||
|
||
m_sut->handleProcessShutdownPreparationRequest(m_processname); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when I call here publisher.offer()
again? Could we test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, in this case the app might be again blocked. It's the responsibility of the application developer to not do this since we have no/less chance to prevent this
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
Same as #697 but this time for master
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References