Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #482 Implement iceoptions, icehello, iceensemble and re-write icedelivery example #698

Conversation

mossmaurice
Copy link
Contributor

@mossmaurice mossmaurice commented Apr 9, 2021

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Branch follows the naming format (iox-#123-this-is-a-branch)
  4. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  5. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  6. Relevant issues are linked
  7. Add sensible notes for the reviewer
  8. All checks have passed (except task-list-completed)
  9. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

mossmaurice and others added 30 commits March 24, 2021 17:09
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
…e iceoptions example

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
…nsemble

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
…move ice_multi_publisher from CMake

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
… name for icedelivery_in_c

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
…w.md to icedelivery

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
…ypos

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
…in examples

Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
…he offer/subscribe

on create option

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
…examples-defined-in-list

Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
…ery example

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
…e functional approach

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
…rammar and extending docu

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
… and removing unnecessary includes

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
…ad' for untyped APIs

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
mossmaurice and others added 3 commits April 7, 2021 11:21
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
…ntences in icedelivery

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
…e docs

Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
@mossmaurice mossmaurice added the documentation Improvements or additions to documentation label Apr 9, 2021
@mossmaurice mossmaurice self-assigned this Apr 9, 2021
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #698 (196cb13) into master (790e3e2) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
- Coverage   74.53%   74.52%   -0.01%     
==========================================
  Files         317      315       -2     
  Lines       11217    11213       -4     
  Branches     1969     1969              
==========================================
- Hits         8361     8357       -4     
- Misses       2079     2082       +3     
+ Partials      777      774       -3     
Flag Coverage Δ
unittests 74.47% <ø> (-0.02%) ⬇️
unittests_timing 31.13% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...posh/roudi/memory/iceoryx_roudi_memory_manager.hpp 12.50% <0.00%> (-87.50%) ⬇️
...ils/include/iceoryx_utils/internal/cxx/smart_c.inl 87.50% <0.00%> (-1.57%) ⬇️
iceoryx_utils/source/posix_wrapper/timer.cpp 60.52% <0.00%> (-0.44%) ⬇️
iceoryx_posh/source/roudi/roudi.cpp 56.09% <0.00%> (-0.27%) ⬇️
iceoryx_posh/source/roudi/process_manager.cpp 64.13% <0.00%> (-0.20%) ⬇️
...posh/include/iceoryx_posh/internal/roudi/roudi.hpp 77.77% <0.00%> (ø)
...osh/source/roudi/application/iceoryx_roudi_app.cpp 30.76% <0.00%> (ø)
...urce/roudi/memory/iceoryx_roudi_memory_manager.cpp 87.50% <0.00%> (ø)
iceoryx_posh/source/roudi/roudi_lock.cpp
...include/iceoryx_posh/internal/roudi/roudi_lock.hpp
... and 4 more

@dkroenke dkroenke merged commit 4dc2048 into eclipse-iceoryx:master Apr 9, 2021
marthtz pushed a commit to boschglobal/iceoryx that referenced this pull request May 12, 2021
…-examples-defined-in-list

Iox eclipse-iceoryx#482 Implement iceoptions, icehello, iceensemble and re-write icedelivery example
@FerdinandSpitzschnueffler FerdinandSpitzschnueffler deleted the iox-#482-implement-examples-defined-in-list branch January 21, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants