iox-#615 unblock RouDi shutdown with blocked publisher

[elBoberido]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Branch follows the naming format (iox-#123-this-is-a-branch)
4. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit messages are signed (git commit -s)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
5. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
6. Relevant issues are linked
7. Add sensible notes for the reviewer
8. All required checks have passed (except task-list-completed)
9. Assign PR to reviewer

Notes for Reviewer

This fixes the issue that a blocked publisher blocks the RouDi shutdown. It's manually tested and a automated test will follow. I created the PR to get the fix into the next RC.

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Partly closes Possibility to block the publisher when subscriber queue is full #615

[codecov]

Codecov Report

Merging #681 (8f66334) into release_1.0 (e6a3293) will decrease coverage by 0.08%.
The diff coverage is 23.07%.

@@               Coverage Diff               @@
##           release_1.0     #681      +/-   ##
===============================================
- Coverage        74.54%   74.46%   -0.09%     
===============================================
  Files              317      317              
  Lines            11217    11224       +7     
  Branches          1969     1970       +1     
===============================================
- Hits              8362     8358       -4     
- Misses            2078     2087       +9     
- Partials           777      779       +2     

Flag	Coverage Δ
unittests	74.42% <23.07%> (-0.09%)	⬇️
unittests_timing	31.35% <23.07%> (+0.11%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...clude/iceoryx_posh/internal/roudi/port_manager.hpp	100.00% <ø> (ø)
iceoryx_posh/source/roudi/port_manager.cpp	74.83% <0.00%> (-1.76%)	⬇️
iceoryx_posh/source/roudi/process_manager.cpp	64.13% <0.00%> (-0.20%)	⬇️
iceoryx_posh/source/roudi/roudi.cpp	56.09% <60.00%> (-0.27%)	⬇️
iceoryx_utils/source/posix_wrapper/timer.cpp	59.64% <0.00%> (-1.76%)	⬇️
...ils/include/iceoryx_utils/internal/cxx/smart_c.inl	87.50% <0.00%> (-1.57%)	⬇️
...nternal/roudi/introspection/port_introspection.inl	72.62% <0.00%> (+0.72%)	⬆️

[mossmaurice]

This could be renamed:

Suggested change

	m_runIpcChannelThread = false;
	m_runRuntimeMessagesThread = false;

[elBoberido]

yes, will do it in the follow up

[mossmaurice]

Can we please rename this thread to something saner at some point? I just mixed up m_processMan.. and m_processRun.. :P

Maybe m_monitorAndDiscoveryThread and m_handleRuntimeMessageThread?