-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #482 rework installation manuals #630
Iox #482 rework installation manuals #630
Conversation
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
==========================================
+ Coverage 73.72% 73.77% +0.05%
==========================================
Files 317 318 +1
Lines 11044 11063 +19
Branches 1946 1947 +1
==========================================
+ Hits 8142 8162 +20
+ Misses 2137 2135 -2
- Partials 765 766 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just some minor findings, mostly typos.
1e3c687
to
c64bcf6
Compare
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
…lation guide Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
… Contributing.md Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
002c5d5
to
e4ab4b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…guides Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
e4ab4b8
to
785725d
Compare
…n-manuals Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
…ing.md Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
…stallation-manuals Iox eclipse-iceoryx#482 rework installation manuals
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
Reworking the installation manuals as preparation for the 1.0 release.
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References