-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #556 release 1.0 preparation #593
Iox #556 release 1.0 preparation #593
Conversation
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
14e73e1
to
ef7fed5
Compare
…d NOTICE.md Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't do a thorough review, just skimmed over some files
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
==========================================
- Coverage 73.94% 73.89% -0.05%
==========================================
Files 318 318
Lines 11106 11110 +4
Branches 1955 1955
==========================================
- Hits 8212 8210 -2
- Misses 2126 2133 +7
+ Partials 768 767 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
eecdfff
to
7e1c8c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looked only at the cmake version stuff
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer IOX
over a ICEORYX
prefix since it's less to type. We should try to be consistent though. In our C++ codebase we use iox
and in cmake we used ICEORYX
. Maybe we should also switch in cmake completely to IOX
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
…ions Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
…ease-preparation Iox eclipse-iceoryx#556 release 1.0 preparation
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
This PR prepare some formal aspects for the upcoming 1.0 release.
Additonally a release build job is added for deploying a debian package.
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References