Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #556 release 1.0 preparation #593

Merged

Conversation

dkroenke
Copy link
Member

@dkroenke dkroenke commented Mar 3, 2021

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Branch follows the naming format (iox-#123-this-is-a-branch)
  4. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  5. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  6. Relevant issues are linked
  7. Add sensible notes for the reviewer
  8. All checks have passed (except task-list-completed)
  9. Assign PR to reviewer

Notes for Reviewer

This PR prepare some formal aspects for the upcoming 1.0 release.
Additonally a release build job is added for deploying a debian package.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
@dkroenke dkroenke added documentation Improvements or additions to documentation tooling All iceoryx related tooling (scripts etc.) labels Mar 3, 2021
@dkroenke dkroenke self-assigned this Mar 3, 2021
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
@dkroenke dkroenke force-pushed the iox-#556-major-release-preparation branch from 14e73e1 to ef7fed5 Compare March 3, 2021 16:59
.github/workflows/changelog.yml Show resolved Hide resolved
cmake/package/package.cmake Show resolved Hide resolved
doc/3rd_party_licenses/cpptoml/LICENSE Show resolved Hide resolved
limitations.md Outdated Show resolved Hide resolved
limitations.md Outdated Show resolved Hide resolved
NOTICE.md Outdated Show resolved Hide resolved
limitations.md Outdated Show resolved Hide resolved
orecham
orecham previously approved these changes Mar 4, 2021
…d NOTICE.md

Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
orecham
orecham previously approved these changes Mar 4, 2021
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do a thorough review, just skimmed over some files

CHANGELOG.md Outdated Show resolved Hide resolved
NOTICE.md Show resolved Hide resolved
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #593 (a9c8930) into master (45a3f41) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
- Coverage   73.94%   73.89%   -0.05%     
==========================================
  Files         318      318              
  Lines       11106    11110       +4     
  Branches     1955     1955              
==========================================
- Hits         8212     8210       -2     
- Misses       2126     2133       +7     
+ Partials      768      767       -1     
Flag Coverage Δ
unittests 73.85% <ø> (-0.05%) ⬇️
unittests_timing 31.59% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._utils/source/posix_wrapper/unix_domain_socket.cpp 56.68% <0.00%> (-1.85%) ⬇️
...nclude/iceoryx_utils/internal/cxx/forward_list.inl 89.03% <0.00%> (-0.79%) ⬇️
..._utils/include/iceoryx_utils/internal/cxx/list.inl 90.03% <0.00%> (-0.70%) ⬇️
...ils/include/iceoryx_utils/internal/cxx/smart_c.inl 90.62% <0.00%> (+3.12%) ⬆️

orecham
orecham previously approved these changes Mar 17, 2021
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
@dkroenke dkroenke force-pushed the iox-#556-major-release-preparation branch from eecdfff to 7e1c8c5 Compare March 23, 2021 17:00
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked only at the cmake version stuff

cmake/package/package.cmake Outdated Show resolved Hide resolved
iceoryx_utils/cmake/IceoryxVersion.cmake Outdated Show resolved Hide resolved
iceoryx_utils/CMakeLists.txt Outdated Show resolved Hide resolved
VERSION Outdated Show resolved Hide resolved
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer IOX over a ICEORYX prefix since it's less to type. We should try to be consistent though. In our C++ codebase we use iox and in cmake we used ICEORYX. Maybe we should also switch in cmake completely to IOX

cmake/package/package.cmake Outdated Show resolved Hide resolved
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
README.md Outdated Show resolved Hide resolved
doc/aspice_swe3_4/CMakeLists.txt Show resolved Hide resolved
limitations.md Outdated Show resolved Hide resolved
limitations.md Outdated Show resolved Hide resolved
limitations.md Outdated Show resolved Hide resolved
limitations.md Outdated Show resolved Hide resolved
limitations.md Outdated Show resolved Hide resolved
limitations.md Outdated Show resolved Hide resolved
…ions

Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
VERSION Outdated Show resolved Hide resolved
iceoryx_meta/package.xml Outdated Show resolved Hide resolved
limitations.md Outdated Show resolved Hide resolved
tools/iceoryx_build_test.sh Outdated Show resolved Hide resolved
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
CHANGELOG.md Outdated Show resolved Hide resolved
mossmaurice
mossmaurice previously approved these changes Mar 31, 2021
Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
@dkroenke dkroenke merged commit 3f6e846 into eclipse-iceoryx:master Mar 31, 2021
@dkroenke dkroenke deleted the iox-#556-major-release-preparation branch March 31, 2021 08:00
marthtz pushed a commit to boschglobal/iceoryx that referenced this pull request May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iceoryx 1.0, Eclipse release preparation
6 participants