Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release_build_publish.yml #2009

Closed
wants to merge 1 commit into from

Conversation

mosfet80
Copy link

@mosfet80 mosfet80 commented Aug 29, 2023

updated actions/upload-artifact

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

  • Closes TBD

updated  actions/upload-artifact
@elfenpiff elfenpiff self-requested a review August 29, 2023 08:45
@elfenpiff
Copy link
Contributor

@mosfet80 Please:

  1. fill out the PR author check list
  2. create a little issue that describes the work you have done (one sentence suffices)
  3. link the issue at the end in the reference section, see Closes ... keyword.
  4. please add the suffix iox-??? to your commit message where ??? is the issue number.

If this is done we can merge it.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #2009 (da66aae) into master (414784e) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2009      +/-   ##
==========================================
- Coverage   74.31%   74.29%   -0.02%     
==========================================
  Files         414      414              
  Lines       16085    16085              
  Branches     2248     2248              
==========================================
- Hits        11954    11951       -3     
  Misses       3416     3416              
- Partials      715      718       +3     
Flag Coverage Δ
unittests 74.08% <ø> (-0.02%) ⬇️
unittests_timing 14.90% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@elBoberido
Copy link
Member

  1. create a little issue that describes the work you have done (one sentence suffices)

@elfenpiff I think we have to streamline our workflow for stuff like this. It unnecessarily increases the entry hurdle for small maintenance commits like this.

@mosfet80 thanks for your contribution. Since this software might end up in cars which could end in harming people there are some requirements we need to follow when it comes to traceability. While this is important for code, it isn't an issue for CI maintenance tasks. Therefore I created #2011 which you can use for your commit message, i.e. iox-#2011 Update release_build_publish.yml. Please follow the steps elfenpiff pointed out but on step 3 it should be just Relates to #2011 in order to not close the issue. I hope this formalism does not scare you away :)

@elBoberido elBoberido mentioned this pull request Aug 29, 2023
21 tasks
@elBoberido
Copy link
Member

@mosfet80 I can take care of this if the formalism is too much for this little change. I have a few open PRs where I can sneak this in.

@elBoberido
Copy link
Member

I updated the actions with #2021

@mosfet80 looking forward to more contributions from you and I hove the formalism does not scare you away :)

@elBoberido elBoberido closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants