whitespace cleanup #2
Conversation
Signed-off-by: Knese Karsten <karsten.knese@us.bosch.com>
|
Hi, thanks for this PR! Especially trailing white spaces are a pain. Could you create an issue and link it with this PR (adding it to the commit message would be great as well) so that one can trace all the changes back to a Github issue? Cheers! |
|
@mossmaurice @dkroenke Any update on this? |
| @@ -29,7 +29,7 @@ using SamplePtr = std::unique_ptr<TopicType, SampleDeleter<TopicType>>; | |||
| /// @brief A typed publisher that takes the topic type as template argument | |||
| /// A RAII pattern is used with offering the the publisher in c'tor and stop offering in d'tor | |||
| /// This class has the limitation that the topic type is a fixed size data structure. | |||
| /// I.e. we can get the size of memory to allcoate with the sizeof() operation. | |||
| /// I.e. we can get the size of memory to allcoate with the sizeof() operation. | |||
There was a problem hiding this comment.
addressed in a204c13
| @@ -50,8 +50,8 @@ MePooConfig& MePooConfig::setDefaults() noexcept | |||
| m_mempoolConfig.push_back({1024 * 1024 * 2, 20}); | |||
| m_mempoolConfig.push_back({1024 * 1024 * 4, 10}); | |||
| m_mempoolConfig.push_back({1024 * 1024 * 8, 10}); | |||
| m_mempoolConfig.push_back({1024 * 1024 * 16, 5}); | |||
There was a problem hiding this comment.
the default mempool configuration reserves nearly 500 megabytes of RAM, with your adaptions it would consume approx. 730 megabytes. Is this intended?
On the side i take the point with me to provide an example with a custom-sized mempool in RouDi for the user.
There was a problem hiding this comment.
legacy changes for presentation.
Signed-off-by: Knese Karsten <karsten.knese@us.bosch.com>
|
Please find the latest commit which addresses your comments. |
Signed-off-by: Hintz Martin (CC-AD/ESW1) <martin.hintz@de.bosch.com>
fixes #5
as per title. There are a bunch of trailing whitespaces in iceoryx at the moment.
Signed-off-by: Knese Karsten karsten.knese@us.bosch.com