Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1998 enable bazel build with clang #1999

Merged

Conversation

phongt
Copy link
Contributor

@phongt phongt commented Jul 10, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@mossmaurice mossmaurice added the tooling All iceoryx related tooling (scripts etc.) label Jul 11, 2023
@mossmaurice mossmaurice self-requested a review July 11, 2023 08:30
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #1999 (fd2e5dd) into master (ebbbb0d) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1999      +/-   ##
==========================================
- Coverage   74.32%   74.30%   -0.02%     
==========================================
  Files         414      414              
  Lines       16086    16086              
  Branches     2249     2249              
==========================================
- Hits        11956    11953       -3     
  Misses       3416     3416              
- Partials      714      717       +3     
Flag Coverage Δ
unittests 74.09% <ø> (-0.02%) ⬇️
unittests_timing 14.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

elBoberido
elBoberido previously approved these changes Jul 11, 2023
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. LGTM

Thanks for your contribution

@elBoberido
Copy link
Member

@phongt please change Closes TBD to Closes #1998 in the PR description

@phongt
Copy link
Contributor Author

phongt commented Jul 11, 2023

@phongt please change Closes TBD to Closes #1998 in the PR description

Done.

@elfenpiff elfenpiff merged commit efc697c into eclipse-iceoryx:master Jul 19, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling All iceoryx related tooling (scripts etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Bazel build with clang
4 participants