Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1036 move creation pattern to dust #1852

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jan 19, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

This PR moves the Creation design pattern to dust and adjusts the UnixDomainSocket. The UnixDomainSocket will later on be ported to the Builder pattern.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido self-assigned this Jan 19, 2023
@elBoberido elBoberido added the refactoring Refactor code without adding features label Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1852 (fca322e) into master (9f96934) will increase coverage by 0.02%.
The diff coverage is 66.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
+ Coverage   75.46%   75.49%   +0.02%     
==========================================
  Files         375      376       +1     
  Lines       14594    14602       +8     
  Branches     2070     2072       +2     
==========================================
+ Hits        11014    11024      +10     
+ Misses       2950     2949       -1     
+ Partials      630      629       -1     
Flag Coverage Δ
unittests 75.16% <66.05%> (+0.02%) ⬆️
unittests_timing 15.23% <10.74%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oryx_dust/include/iceoryx_dust/design/creation.hpp 100.00% <ø> (ø)
...st/include/iceoryx_dust/internal/cli/arguments.inl 0.00% <0.00%> (ø)
...de/iceoryx_dust/internal/cli/option_definition.hpp 0.00% <ø> (ø)
...clude/iceoryx_dust/internal/cli/option_manager.inl 0.00% <0.00%> (ø)
...clude/iceoryx_dust/internal/cxx/static_storage.hpp 0.00% <ø> (ø)
...clude/iceoryx_dust/internal/cxx/static_storage.inl 0.00% <0.00%> (ø)
.../include/iceoryx_dust/posix_wrapper/named_pipe.hpp 100.00% <ø> (ø)
...lude/iceoryx_dust/posix_wrapper/signal_watcher.hpp 0.00% <ø> (ø)
iceoryx_dust/source/cli/command_line_parser.cpp 0.00% <0.00%> (ø)
iceoryx_dust/source/cli/option_definition.cpp 0.00% <0.00%> (ø)
... and 180 more

dkroenke
dkroenke previously approved these changes Jan 20, 2023
Copy link
Member

@dkroenke dkroenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, one small nitpick.

iceoryx_dust/include/iceoryx_dust/design/creation.hpp Outdated Show resolved Hide resolved
@dkroenke dkroenke self-requested a review January 23, 2023 13:01
@elBoberido elBoberido merged commit b9466d6 into eclipse-iceoryx:master Jan 23, 2023
@elBoberido elBoberido deleted the iox-1036-move-creation-pattern-to-dust branch January 23, 2023 13:14
@elBoberido elBoberido linked an issue Jan 23, 2023 that may be closed by this pull request
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove creation design pattern class with in place implementation
3 participants