-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1036 move creation pattern to dust #1852
iox-#1036 move creation pattern to dust #1852
Conversation
iceoryx_hoofs/include/iceoryx_hoofs/internal/posix_wrapper/unix_domain_socket.hpp
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1852 +/- ##
==========================================
+ Coverage 75.46% 75.49% +0.02%
==========================================
Files 375 376 +1
Lines 14594 14602 +8
Branches 2070 2072 +2
==========================================
+ Hits 11014 11024 +10
+ Misses 2950 2949 -1
+ Partials 630 629 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, one small nitpick.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
This PR moves the
Creation
design pattern to dust and adjusts theUnixDomainSocket
. TheUnixDomainSocket
will later on be ported to theBuilder
pattern.Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References