-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#743 Validate callbacks in c example #1188
Merged
FerdinandSpitzschnueffler
merged 3 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#743-validate-callbacks-in-c-example
Mar 3, 2022
Merged
iox-#743 Validate callbacks in c example #1188
FerdinandSpitzschnueffler
merged 3 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#743-validate-callbacks-in-c-example
Mar 3, 2022
+102
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FerdinandSpitzschnueffler
added
the
documentation
Improvements or additions to documentation
label
Mar 1, 2022
elBoberido
previously approved these changes
Mar 1, 2022
Codecov Report
@@ Coverage Diff @@
## master #1188 +/- ##
==========================================
+ Coverage 79.06% 79.12% +0.06%
==========================================
Files 370 370
Lines 14660 14660
Branches 2046 2046
==========================================
+ Hits 11591 11600 +9
+ Misses 2399 2393 -6
+ Partials 670 667 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mossmaurice
reviewed
Mar 2, 2022
elBoberido
reviewed
Mar 2, 2022
elfenpiff
reviewed
Mar 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, when elBoberido's finding is fixed it is ready to merge.
FerdinandSpitzschnueffler
force-pushed
the
iox-#743-validate-callbacks-in-c-example
branch
from
March 2, 2022 11:02
79d4d9f
to
f2336ed
Compare
elfenpiff
previously approved these changes
Mar 2, 2022
elBoberido
previously approved these changes
Mar 2, 2022
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
FerdinandSpitzschnueffler
force-pushed
the
iox-#743-validate-callbacks-in-c-example
branch
from
March 2, 2022 17:53
f4998e4
to
c587867
Compare
MatthiasKillat
approved these changes
Mar 2, 2022
elfenpiff
approved these changes
Mar 3, 2022
FerdinandSpitzschnueffler
deleted the
iox-#743-validate-callbacks-in-c-example
branch
March 3, 2022 10:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References