Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#27 Add client and server port to PortPool and PortManager [stacked PR #2] #1084
iox-#27 Add client and server port to PortPool and PortManager [stacked PR #2] #1084
Changes from all commits
0c14d63
e1a69e2
d72c5dc
82d4354
a57e877
751b175
9dff244
92c8e8e
bd58768
4f1433f
ddc568d
5f610c9
d6b796b
32b2648
b0dc5df
d51c019
95e91d0
2546ec0
a16d520
fa5bd4c
3740311
f462314
ebf207a
70e746d
97e6630
56768ff
fe2ff90
4439fa5
4243c6a
985b036
9eea005
5a1bf33
4a550b8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no you used the dont touch me container ... Who renamed it into
FixedPositionContainer
...Actually you could use the
cxx::list
here.But this is up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually something like the
UsedChunkList
would be perfect for this situation but this is something for the future self