Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SOFI real size equal to the specified one #105

Closed
elBoberido opened this issue May 14, 2020 · 0 comments · Fixed by #107
Closed

Make SOFI real size equal to the specified one #105

elBoberido opened this issue May 14, 2020 · 0 comments · Fixed by #107
Assignees
@elBoberido
Labels
bug Something isn't working

Comments

@elBoberido
Copy link
Member

Required information

Operating system:
all

Compiler version:
all

Observed result or behaviour:
The SOFI holds one extry element before the overflowing mechanism takes action.
So in the single threaded case, a full SOFI always provides one more element than the configured size. This is a surprising behaviour.

Expected result or behaviour:
A full SOFI should not provide more elements than specified.

Conditions where it occurred / Performed steps:

  • push to the SOFI until an overflow occurs
  • pop until empty and count the pops
  • the pop count should be equal to the configured size, but it's off by one
elBoberido added a commit to elBoberido/iceoryx that referenced this issue May 14, 2020
@elBoberido
iox-eclipse-iceoryx#105 make SOFI real size equal to the specified one
9d5cca4 
Signed-off-by: Kraus Mathias (CC-AD/ESW1) <mathias.kraus2@de.bosch.com>
@elBoberido elBoberido linked a pull request May 14, 2020 that will close this issue
Iox #105 make sofi real size equal to the specified one #107
Merged
@elBoberido elBoberido added the bug Something isn't working label May 14, 2020
@elBoberido elBoberido self-assigned this May 14, 2020
elBoberido added a commit to elBoberido/iceoryx that referenced this issue May 20, 2020
@elBoberido
iox-eclipse-iceoryx#105 add comment regarding memory ordering
2b877fb 
Signed-off-by: Kraus Mathias (CC-AD/ESW1) <mathias.kraus2@de.bosch.com>
elBoberido added a commit that referenced this issue May 28, 2020
@elBoberido
Merge pull request #107 from elBoberido/iox-#105-make-SOFI-real-size-…
0a2b10b 
…equal-to-the-specified-one

Iox #105 make sofi real size equal to the specified one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elBoberido elBoberido

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Iox #105 make sofi real size equal to the specified one elBoberido/iceoryx
1 participant
@elBoberido