iox-#2011 Silence some warnings when building with GCC 13.

GCC 13 (which is in Ubuntu 24.04) introduced a number of false positive warnings when using -Warray-bounds and -Wstring-op; see: * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114758 * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111118 * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110807 * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110498 In my testing, these only show up when building with optimizations, i.e. CMAKE_BUILD_TYPE=RelWithDebInfo. This commit silences those warnings across the two functions that cause the problem, and make the build completely clean. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
eclipse-iceoryx · Jun 3, 2024 · 434ee45 · 434ee45
1 parent 6d357df
commit 434ee45
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/doc/website/release-notes/iceoryx-unreleased.md b/doc/website/release-notes/iceoryx-unreleased.md
@@ -12,6 +12,8 @@
 
 **Refactoring:**
 
+- Silence warnings when building with GCC 13 [\#2011](https://github.com/eclipse-iceoryx/iceoryx/issues/2011)
+
 **New API features:**
 
 **API Breaking Changes:**

diff --git a/iceoryx_hoofs/include/iceoryx_hoofs/internal/cxx/variant_queue.inl b/iceoryx_hoofs/include/iceoryx_hoofs/internal/cxx/variant_queue.inl
@@ -17,6 +17,7 @@
 #ifndef IOX_HOOFS_CXX_VARIANT_QUEUE_INL
 #define IOX_HOOFS_CXX_VARIANT_QUEUE_INL
 
+#include "iceoryx_hoofs/cxx/variant_queue.hpp"
 #include "iceoryx_hoofs/error_handling/error_handling.hpp"
 
 namespace iox
@@ -49,6 +50,11 @@ inline VariantQueue<ValueType, Capacity>::VariantQueue(const VariantQueueTypes t
     }
 }
 
+#if (defined(__GNUC__) && __GNUC__ >= 13 && !defined(__clang__))
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wstringop-overflow"
+#endif
+
 template <typename ValueType, uint64_t Capacity>
 optional<ValueType> VariantQueue<ValueType, Capacity>::push(const ValueType& value) noexcept
 {
@@ -90,6 +96,10 @@ optional<ValueType> VariantQueue<ValueType, Capacity>::push(const ValueType& val
     return cxx::nullopt;
 }
 
+#if (defined(__GNUC__) && __GNUC__ >= 13 && !defined(__clang__))
+#pragma GCC diagnostic pop
+#endif
+
 template <typename ValueType, uint64_t Capacity>
 inline optional<ValueType> VariantQueue<ValueType, Capacity>::pop() noexcept
 {

diff --git a/iceoryx_posh/include/iceoryx_posh/internal/popo/building_blocks/chunk_distributor.inl b/iceoryx_posh/include/iceoryx_posh/internal/popo/building_blocks/chunk_distributor.inl
@@ -132,6 +132,11 @@ inline bool ChunkDistributor<ChunkDistributorDataType>::hasStoredQueues() const
     return !getMembers()->m_queues.empty();
 }
 
+#if (defined(__GNUC__) && __GNUC__ >= 13 && !defined(__clang__))
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Warray-bounds"
+#endif
+
 template <typename ChunkDistributorDataType>
 inline uint64_t ChunkDistributor<ChunkDistributorDataType>::deliverToAllStoredQueues(mepoo::SharedChunk chunk) noexcept
 {
@@ -209,6 +214,10 @@ inline uint64_t ChunkDistributor<ChunkDistributorDataType>::deliverToAllStoredQu
     return numberOfQueuesTheChunkWasDeliveredTo;
 }
 
+#if (defined(__GNUC__) && __GNUC__ >= 13 && !defined(__clang__))
+#pragma GCC diagnostic pop
+#endif
+
 template <typename ChunkDistributorDataType>
 inline bool ChunkDistributor<ChunkDistributorDataType>::pushToQueue(cxx::not_null<ChunkQueueData_t* const> queue,
                                                                     mepoo::SharedChunk chunk) noexcept