Fix domain id argument in create_participant API #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build status:
|
pablogs9
force-pushed
the
fix/domain_id_type
branch
from
c80cd26
to
d0fd33c
Compare
|
Build status:
|
Acuadros95
approved these changes
Mar 29, 2023
Acuadros95
added a commit
that referenced
this pull request
Mar 29, 2023
* Add CMAKE configuration for C standard version (#340) * Add C standard configuration Signed-off-by: acuadros95 <acuadros1995@gmail.com> * Update C define Signed-off-by: acuadros95 <acuadros1995@gmail.com> * Remove CMAKE conditional Signed-off-by: acuadros95 <acuadros1995@gmail.com> --------- Signed-off-by: acuadros95 <acuadros1995@gmail.com> * Fix build for macOS (#346) * Add Twitter and Readthedocs shields (#307) (#308) * Add Twitter and Readthedocs shields Signed-off-by: Pablo Garrido <pablogs9@gmail.com> * Update Signed-off-by: Pablo Garrido <pablogs9@gmail.com> * Fix Signed-off-by: Pablo Garrido <pablogs9@gmail.com> (cherry picked from commit 8b78d22) Co-authored-by: Pablo Garrido <pablogs9@gmail.com> * Fix build for macOS - Add check for CMAKE_SYSTEM_NAME "Darwin". Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> --------- Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Fix newline-eof compiler warning (#347) Add EOF newline to session.c. Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> * Fix doxygen warning (#352) * Remove outdated navindex tag Signed-off-by: acuadros95 <acuadros1995@gmail.com> * Revert unwanted removal Signed-off-by: acuadros95 <acuadros1995@gmail.com> --------- Signed-off-by: acuadros95 <acuadros1995@gmail.com> * Add missing doxygen parameter (#353) Signed-off-by: acuadros95 <acuadros1995@gmail.com> * Fix domain id argument in create_participant API (#348) --------- Signed-off-by: acuadros95 <acuadros1995@gmail.com> Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> Co-authored-by: Rhys Mainwaring <rhys.mainwaring@me.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
pablogs9
added a commit
that referenced
this pull request
Mar 29, 2023
* Add CMAKE configuration for C standard version (#340) * Add C standard configuration Signed-off-by: acuadros95 <acuadros1995@gmail.com> * Update C define Signed-off-by: acuadros95 <acuadros1995@gmail.com> * Remove CMAKE conditional Signed-off-by: acuadros95 <acuadros1995@gmail.com> --------- Signed-off-by: acuadros95 <acuadros1995@gmail.com> * Fix build for macOS (#346) * Add Twitter and Readthedocs shields (#307) (#308) * Add Twitter and Readthedocs shields Signed-off-by: Pablo Garrido <pablogs9@gmail.com> * Update Signed-off-by: Pablo Garrido <pablogs9@gmail.com> * Fix Signed-off-by: Pablo Garrido <pablogs9@gmail.com> (cherry picked from commit 8b78d22) Co-authored-by: Pablo Garrido <pablogs9@gmail.com> * Fix build for macOS - Add check for CMAKE_SYSTEM_NAME "Darwin". Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> --------- Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Fix newline-eof compiler warning (#347) Add EOF newline to session.c. Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> * Fix doxygen warning (#352) * Remove outdated navindex tag Signed-off-by: acuadros95 <acuadros1995@gmail.com> * Revert unwanted removal Signed-off-by: acuadros95 <acuadros1995@gmail.com> --------- Signed-off-by: acuadros95 <acuadros1995@gmail.com> * Add missing doxygen parameter (#353) Signed-off-by: acuadros95 <acuadros1995@gmail.com> * Fix domain id argument in create_participant API (#348) --------- Signed-off-by: acuadros95 <acuadros1995@gmail.com> Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> Co-authored-by: Rhys Mainwaring <rhys.mainwaring@me.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs update: eProsima/Micro-XRCE-DDS-docs#85
Merge before next release