Pedatic warnings

examples/BinaryEntityCreation/main.c

@@ -31,7 +31,7 @@ void on_topic(
         uint16_t length,
         void* args)
 {
-    (void) session; (void) object_id; (void) request_id; (void) stream_id; (void) length;
+    (void) session; (void) object_id; (void) request_id; (void) stream_id; (void) length; (void) args;
 
     int32_t data;
     ucdr_deserialize_int32_t(ub, &data);
@@ -122,8 +122,8 @@ int main(
         0
     };
     delivery_control.max_samples = UXR_MAX_SAMPLES_UNLIMITED;
-    uint16_t read_data_req = uxr_buffer_request_data(&session, reliable_out, datareader_id, reliable_in,
-                    &delivery_control);
+    uxr_buffer_request_data(&session, reliable_out, datareader_id, reliable_in,
+            &delivery_control);
 
     // Write topics
     bool connected = true;

examples/ContinuousFragment/main.c

@@ -76,8 +76,8 @@ int main(
             "</rtps>"
             "</participant>"
             "</dds>";
-    uint16_t participant_req = uxr_buffer_create_participant_xml(&session, reliable_out, participant_id, 0,
-                    participant_xml, UXR_REPLACE);
+    uxr_buffer_create_participant_xml(&session, reliable_out, participant_id, 0,
+            participant_xml, UXR_REPLACE);
     uxr_run_session_until_confirm_delivery(&session, 100);
     uxrObjectId topic_id = uxr_object_id(0x01, UXR_TOPIC_ID);
     const char* topic_xml = "<dds>"
@@ -86,13 +86,13 @@ int main(
             "<dataType>HelloWorld</dataType>"
             "</topic>"
             "</dds>";
-    uint16_t topic_req = uxr_buffer_create_topic_xml(&session, reliable_out, topic_id, participant_id, topic_xml,
-                    UXR_REPLACE);
+    uxr_buffer_create_topic_xml(&session, reliable_out, topic_id, participant_id, topic_xml,
+            UXR_REPLACE);
     uxr_run_session_until_confirm_delivery(&session, 100);
     uxrObjectId publisher_id = uxr_object_id(0x01, UXR_PUBLISHER_ID);
     const char* publisher_xml = "";
-    uint16_t publisher_req = uxr_buffer_create_publisher_xml(&session, reliable_out, publisher_id, participant_id,
-                    publisher_xml, UXR_REPLACE);
+    uxr_buffer_create_publisher_xml(&session, reliable_out, publisher_id, participant_id,
+            publisher_xml, UXR_REPLACE);
 
     uxrObjectId datawriter_id = uxr_object_id(0x01, UXR_DATAWRITER_ID);
     const char* datawriter_xml = "<dds>"
@@ -105,12 +105,13 @@ int main(
             "</topic>"
             "</data_writer>"
             "</dds>";
-    uint16_t datawriter_req = uxr_buffer_create_datawriter_xml(&session, reliable_out, datawriter_id, publisher_id,
-                    datawriter_xml, UXR_REPLACE);
+    uxr_buffer_create_datawriter_xml(&session, reliable_out, datawriter_id, publisher_id,
+            datawriter_xml, UXR_REPLACE);
+
     uxr_run_session_until_confirm_delivery(&session, 100);
 
     // Write topic
-    uint8_t buf[20000];
+    char buf[20000];
     memset(buf, 'A', sizeof(buf));
 
     ucdrBuffer ub;

examples/CustomTransports/main.c

@@ -29,6 +29,9 @@ int main(
         int args,
         char** argv)
 {
+    (void) args;
+    (void) argv;
+
     // Transport
     uxrCustomTransport transport;
     uxr_set_custom_transport_callbacks(

examples/CustomTransports/my_custom_transport.c

@@ -13,6 +13,8 @@ static struct pollfd poll_fd;
 bool my_custom_transport_open(
         uxrCustomTransport* transport)
 {
+    (void) transport;
+
     printf("Micro XRCE-DDS Client Custom transport: opening\n");
 
     bool rv = false;
@@ -49,6 +51,8 @@ bool my_custom_transport_open(
 bool my_custom_transport_close(
         uxrCustomTransport* transport)
 {
+    (void) transport;
+
     printf("Micro XRCE-DDS Client Custom transport: closing\n");
 
     return (-1 == poll_fd.fd) ? true : (0 == close(poll_fd.fd));
@@ -60,6 +64,8 @@ size_t my_custom_transport_write(
         size_t len,
         uint8_t* errcode)
 {
+    (void) transport;
+
     size_t rv = 0;
     ssize_t bytes_sent = send(poll_fd.fd, (void*)buf, len, 0);
     if (-1 != bytes_sent)
@@ -84,6 +90,8 @@ size_t my_custom_transport_read(
         int timeout,
         uint8_t* errcode)
 {
+    (void) transport;
+
     size_t rv = 0;
     int poll_rv = poll(&poll_fd, 1, timeout);
     if (0 < poll_rv)

examples/CustomTransports/my_custom_transport.h

@@ -34,4 +34,4 @@ size_t my_custom_transport_read(
         int timeout,
         uint8_t* errcode);
 
-#endif // ifndef _my_custom_transport_H_
+#endif // ifndef _my_custom_transport_H_

examples/Discovery/main.c

@@ -73,7 +73,7 @@ int main(
         TransportLocator agent_list[MAX_AGENTS];
         for (int i = 1; i < args; i += 2, size++)
         {
-            uxr_ip_to_locator(argv[i], (uint16_t)atoi(argv[i + 1]), UXR_IPv4, &agent_list[i++]);
+            uxr_ip_to_locator(argv[i], (uint16_t)atoi(argv[i + 1]), UXR_IPv4, &agent_list[size]);
         }
 
         uxr_discovery_agents(10, 1000, on_agent_found, NULL, agent_list, size);

examples/MultiSessionHelloWorld/main.c

@@ -33,7 +33,7 @@ void on_topic(
         uint16_t length,
         void* args)
 {
-    (void) session; (void) object_id; (void) request_id; (void) stream_id; (void) length;
+    (void) object_id; (void) request_id; (void) stream_id; (void) length; (void) args;
 
     HelloWorld topic;
     HelloWorld_deserialize_topic(ub, &topic);
@@ -282,10 +282,10 @@ int main(
         0
     };
     delivery_control.max_samples = UXR_MAX_SAMPLES_UNLIMITED;
-    uint16_t read_data_req_1 = uxr_buffer_request_data(&session_1, reliable_out_1, datareader_id_1, reliable_in_1,
-                    &delivery_control);
-    uint16_t read_data_req_2 = uxr_buffer_request_data(&session_2, reliable_out_2, datareader_id_2, reliable_in_2,
-                    &delivery_control);
+    uxr_buffer_request_data(&session_1, reliable_out_1, datareader_id_1, reliable_in_1,
+            &delivery_control);
+    uxr_buffer_request_data(&session_2, reliable_out_2, datareader_id_2, reliable_in_2,
+            &delivery_control);
 
     // Write topics
     uint32_t count = 0;

examples/PingAgent/Serial/main.c

@@ -58,4 +58,4 @@ int main(
 
     return 0;
 #endif  // WIN32
-}
+}

examples/PingAgent/TCP/main.c

@@ -51,4 +51,4 @@ int main(
     uxr_close_tcp_transport(&transport);
 
     return 0;
-}
+}

examples/PingAgent/UDP/main.c

@@ -51,4 +51,4 @@ int main(
     uxr_close_udp_transport(&transport);
 
     return 0;
-}
+}

examples/ReplyAdder/main.c

@@ -40,6 +40,7 @@ void on_request(
     (void) object_id;
     (void) request_id;
     (void) length;
+    (void) args;
 
     uint32_t rhs;
     uint32_t lhs;
@@ -155,4 +156,4 @@ int main(
     }
 
     return 0;
-}
+}

examples/RequestAdder/main.c

@@ -31,9 +31,11 @@ void on_reply(
         uint16_t length,
         void* args)
 {
+    (void) session;
     (void) object_id;
     (void) request_id;
     (void) length;
+    (void) args;
 
     uint64_t result;
     ucdr_deserialize_uint64_t(ub, &result);
@@ -125,8 +127,8 @@ int main(
         0
     };
     delivery_control.max_samples = UXR_MAX_SAMPLES_UNLIMITED;
-    uint16_t read_data_req = uxr_buffer_request_data(&session, reliable_out, requester_id, reliable_in,
-                    &delivery_control);
+    uxr_buffer_request_data(&session, reliable_out, requester_id, reliable_in,
+            &delivery_control);
 
     // Write requests
     bool connected = true;
@@ -150,4 +152,4 @@ int main(
     }
 
     return 0;
-}
+}

examples/SubscribeHelloWorldBestEffort/main.c

@@ -146,8 +146,8 @@ int main(
         0
     };
     delivery_control.max_samples = UXR_MAX_SAMPLES_UNLIMITED;
-    uint16_t read_data_req = uxr_buffer_request_data(&session, reliable_out, datareader_id, besteffort_in,
-                    &delivery_control);
+    uxr_buffer_request_data(&session, reliable_out, datareader_id, besteffort_in,
+            &delivery_control);
 
     // Read topics
     while (count < max_topics)

include/uxr/client/profile/transport/ip/tcp/tcp_transport_posix.h

@@ -34,4 +34,4 @@ typedef struct uxrTCPPlatform
 }
 #endif // ifdef __cplusplus
 
-#endif // UXR_CLIENT_PROFILE_TRANSPORT_IP_TCP_TCPTRANSPORTPOSIX_H_
+#endif // UXR_CLIENT_PROFILE_TRANSPORT_IP_TCP_TCPTRANSPORTPOSIX_H_

include/uxr/client/util/ping.h

@@ -74,4 +74,4 @@ UXRDLLAPI bool uxr_ping_agent_attempts(
 }
 #endif // ifdef __cplusplus
 
-#endif // UXR_CLIENT_UTIL_PING_H_
+#endif // UXR_CLIENT_UTIL_PING_H_

src/c/core/session/read_access.c

@@ -204,7 +204,7 @@ inline void read_format_data(
                         request_id,
                         &sample_id,
                         &temp_buffer,
-                        (size_t)request_length,
+                        request_length,
                         session->on_request_args);
 
                     session->on_data_flag = true;
@@ -232,7 +232,7 @@ inline void read_format_data(
                         request_id,
                         (uint16_t)((request.request_id.data[0] << 8) + request.request_id.data[1]),
                         &temp_buffer,
-                        (size_t)reply_length,
+                        reply_length,
                         session->on_reply_args);
 
                     session->on_data_flag = true;

src/c/profile/transport/ip/ip_posix.c

@@ -70,4 +70,4 @@ bool uxr_locator_to_ip(
             break;
     }
     return result;
-}
+}