Fix FDSET issue

Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
eProsima · Nov 14, 2021 · 8ea7240 · 8ea7240
1 parent 7fe7719
commit 8ea7240
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/src/c/profile/transport/ip/tcp/tcp_transport_rtems_bsd_net.c b/src/c/profile/transport/ip/tcp/tcp_transport_rtems_bsd_net.c
@@ -51,19 +51,11 @@ bool uxr_init_tcp_platform(
         rv = true;
 
         /* Server connection. */
-        if (rv)
-        {
-            int connected = connect(platform->fd,
-                            (struct sockaddr *)&platform->remote_addr,
-                            sizeof(platform->remote_addr));
-            rv = (0 == connected);
-        }
-        else
-        {
-            rv = false;
-        }
+        int connected = connect(platform->fd,
+                        (struct sockaddr *)&platform->remote_addr,
+                        sizeof(platform->remote_addr));
+        rv = (0 == connected);
     }
-
     return rv;
 }
 
@@ -113,6 +105,11 @@ size_t uxr_read_tcp_data_platform(
     tv.tv_sec = timeout/1000;
     tv.tv_usec = (timeout%1000) *1000;
 
+    #pragma GCC diagnostic push
+    #pragma GCC diagnostic ignored "-Wsign-conversion"
+    FD_ZERO(&platform->select_fd);
+    FD_SET(platform->fd, &platform->select_fd);
+    #pragma GCC diagnostic pop
     int32_t poll_rv = select(platform->fd+1, &platform->select_fd, NULL, NULL, &tv);
     if (0 < poll_rv)
     {

diff --git a/src/c/profile/transport/ip/udp/udp_transport_rtems_bsd_net.c b/src/c/profile/transport/ip/udp/udp_transport_rtems_bsd_net.c
@@ -100,6 +100,11 @@ size_t uxr_read_udp_data_platform(
     tv.tv_sec = timeout/1000;
     tv.tv_usec = (timeout%1000) *1000;
 
+    #pragma GCC diagnostic push
+    #pragma GCC diagnostic ignored "-Wsign-conversion"
+    FD_ZERO(&platform->select_fd);
+    FD_SET(platform->fd, &platform->select_fd);
+    #pragma GCC diagnostic pop
     int32_t poll_rv = select(platform->fd+1, &platform->select_fd, NULL, NULL, &tv);
     if (0 < poll_rv)
     {