Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for a union using an alias with scope #5330

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

richiware
Copy link
Member

@richiware richiware commented Oct 16, 2024

Description

Add tests for the regression type for issue #21823 in eProsima/Fast-DDS-Gen#411.

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
test/dds-types-test/unionsPubSubTypes.cxx Outdated Show resolved Hide resolved
module_regexp = r'module\s+(\w+)\s*{((?:.|[\r\n])*?)\};\s*\};'
module_regexp = r'module\s+(\w+)\s*{((?:.|[\r\n])*?)\};'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously the regexp searches:

module MyModule
{
};
};

two square brackets at the end. This provokes a failure with my update in unions.idl.

thirdparty/dds-types-test Outdated Show resolved Hide resolved
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants