[21696] Fix Secure Discovery Server client disposals guid and handshake_handle assertion #5257
+208
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
JesusPoderoso
requested changes
Oct 17, 2024
Comment on lines
+774
to
+778
| if (getRTPSParticipant()->is_secure()) | ||
| { | ||
| // Need the mangled guid prefix in this case | ||
| srv_guid_prefix = get_participant_proxy_data(svr.guidPrefix)->m_guid.guidPrefix; | ||
| } |
There was a problem hiding this comment.
Based on the CI results, it looks like this should be used with security guards.
| set_property(TEST SecureDiscoverServerMultipleClientsDisposalsReceived APPEND PROPERTY ENVIRONMENT | ||
| "PATH=$<TARGET_FILE_DIR:${PROJECT_NAME}>\\;$<TARGET_FILE_DIR:fastcdr>\\;${WIN_PATH}") | ||
| endif() | ||
|
|
|
|
||
| if __name__ == '__main__': | ||
|
|
||
| # Parse arguments | ||
| args = ParseOptions() | ||
|
|
||
| run(args.args) | ||
| run(args.args) |
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Mario-DL
requested review from
JesusPoderoso
and removed request for
JesusPoderoso
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two issues regarding
Secure Discovery Serverguidwas not beaing properly send from clients to server.SecurityManageras a consequence of not being able to retrieve a new change in theparticipant_stateless_msg_writer@Mergifyio backport 2.10.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist