Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21706] Remove unused validMatching methods in EDP #5245

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[21706] Remove unused validMatching methods in EDP #5245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions src/cpp/rtps/builtin/discovery/endpoint/EDP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,15 +564,6 @@ bool EDP::unpairReaderProxy(
return true;
}

bool EDP::validMatching(
const WriterProxyData* wdata,
const ReaderProxyData* rdata)
{
MatchingFailureMask reason;
fastdds::dds::PolicyMask incompatible_qos;
return valid_matching(wdata, rdata, reason, incompatible_qos);
}

bool EDP::valid_matching(
const WriterProxyData* wdata,
const ReaderProxyData* rdata,
Expand Down Expand Up @@ -798,15 +789,6 @@ bool EDP::checkDataRepresentationQos(
return compatible;
}

bool EDP::validMatching(
const ReaderProxyData* rdata,
const WriterProxyData* wdata)
{
MatchingFailureMask reason;
fastdds::dds::PolicyMask incompatible_qos;
return valid_matching(rdata, wdata, reason, incompatible_qos);
}

bool EDP::valid_matching(
const ReaderProxyData* rdata,
const WriterProxyData* wdata,
Expand Down
20 changes: 0 additions & 20 deletions src/cpp/rtps/builtin/discovery/endpoint/EDP.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,26 +212,6 @@ class EDP
RTPSWriter* rtps_writer,
const fastdds::dds::WriterQos& qos);

/**
* Check the validity of a matching between a local RTPSWriter and a ReaderProxyData object.
* @param wdata Pointer to the WriterProxyData object of the local RTPSWriter.
* @param rdata Pointer to the ReaderProxyData object.
* @return True if the two can be matched.
*/
bool validMatching(
const WriterProxyData* wdata,
const ReaderProxyData* rdata);

/**
* Check the validity of a matching between a local RTPSReader and a WriterProxyData object.
* @param rdata Pointer to the ReaderProxyData object of the local RTPSReader.
* @param wdata Pointer to the WriterProxyData object.
* @return True if the two can be matched.
*/
bool validMatching(
const ReaderProxyData* rdata,
const WriterProxyData* wdata);

/**
* Check the validity of a matching between a local RTPSWriter and a ReaderProxyData object.
* @param wdata Pointer to the WriterProxyData object of the local RTPSWriter.
Expand Down
Loading