Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21652] Fix xtypes example segfault if xml env var is not set #5243

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Sep 18, 2024

Description

Example segfault if xml env var is not configured previously:

# missing run: "export FASTDDS_DEFAULT_PROFILES_FILE=<my_profile.xml>"
./build/fastdds/examples/cpp/xtypes/xtypes publisher --xml-type
Error getting dynamic type "HelloWorld".
Segmentation fault (core dumped)

This PR fixes the behavior to correctly fail in that case

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added the needs-review PR that is ready to be reviewed label Sep 18, 2024
@JesusPoderoso JesusPoderoso added this to the v3.0.2 milestone Sep 18, 2024
@JesusPoderoso JesusPoderoso self-assigned this Sep 18, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 18, 2024
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Sep 18, 2024
@JesusPoderoso JesusPoderoso merged commit 013c10c into master Sep 19, 2024
17 checks passed
@JesusPoderoso JesusPoderoso deleted the hotfix/21652 branch September 19, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants