[21479] Allow runing CI on external contributions #5220

JesusPoderoso · 2024-09-10T14:16:41Z

Description

This PR adds some logic to the CI to determine if an external contribution triggers the CI. In such a case, the CI avoids using the external/add_label action which is not allowed in external contribution cases.

A deep research on the literature brings some information regarding possible security issues while using pull_request_target CI triggers. As long as we only use the pull_request trigger, there is no need to include manual confirmation from a Collaborator with required permissions, from now on.

NOTE: Adding the skip-ci label as long as the external contributions CI is tested from the following external PR:

[21479] Allow runing CI on external contributions test #5219

As part of the CI pipelines, this PR needs to be included also in the critical-security-fixes-only 2.6.x supported branch.

@Mergifyio backport 3.0.x 2.14.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
N/A Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
N/A Check CI results: changes do not issue any warning.
N/A Check CI results: failing tests are unrelated with the changes.

MiguelCompany · 2024-09-18T07:21:38Z

@Mergifyio rebase

mergify · 2024-09-18T07:22:00Z

rebase

✅ Branch has been successfully rebased

MiguelCompany

Perhaps we could make a separate workflow for PR labeling?

MiguelCompany

Apart from my comments below, this needs a rebase after #5285

.github/workflows/reusable-ubuntu-ci.yml

.github/workflows/ubuntu-ci.yml

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Signed-off-by: eProsima <jesuspoderoso@eprosima.com>

MiguelCompany

LGTM with green build on #5242

MiguelCompany · 2024-10-02T10:36:52Z

@Mergifyio backport 3.0.x 2.14.x 2.10.x 2.6.x

mergify · 2024-10-02T10:37:04Z

backport 3.0.x 2.14.x 2.10.x 2.6.x

✅ Backports have been created

#5287 [21479] Allow runing CI on external contributions (backport #5220) has been created for branch 3.0.x
#5288 [21479] Allow runing CI on external contributions (backport #5220) has been created for branch 2.14.x
#5289 [21479] Allow runing CI on external contributions (backport #5220) has been created for branch 2.10.x
#5290 [21479] Allow runing CI on external contributions (backport #5220) has been created for branch 2.6.x

* Refs #21479: Include labeling check Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21479: Keep 'Add label' job only in ubuntu workflow Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21479: Apply rev suggestions Signed-off-by: eProsima <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: eProsima <jesuspoderoso@eprosima.com> (cherry picked from commit 2d1e793)

* Refs #21479: Include labeling check Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21479: Keep 'Add label' job only in ubuntu workflow Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21479: Apply rev suggestions Signed-off-by: eProsima <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: eProsima <jesuspoderoso@eprosima.com> (cherry picked from commit 2d1e793) Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>

JesusPoderoso added the skip-ci Automatically pass CI label Sep 10, 2024

JesusPoderoso added this to the v3.0.2 milestone Sep 10, 2024

JesusPoderoso self-assigned this Sep 10, 2024

JesusPoderoso added the needs-review PR that is ready to be reviewed label Sep 10, 2024

MiguelCompany force-pushed the feature/allow_external_CI branch from 68b289e to 206be41 Compare September 18, 2024 07:22

JesusPoderoso force-pushed the feature/allow_external_CI branch from 206be41 to e924aaa Compare September 18, 2024 08:27

MiguelCompany reviewed Sep 19, 2024

View reviewed changes

MiguelCompany modified the milestones: v3.0.2, v3.1.0 Oct 2, 2024

MiguelCompany requested changes Oct 2, 2024

View reviewed changes

.github/workflows/reusable-ubuntu-ci.yml Outdated Show resolved Hide resolved

.github/workflows/ubuntu-ci.yml Outdated Show resolved Hide resolved

MiguelCompany removed the needs-review PR that is ready to be reviewed label Oct 2, 2024

JesusPoderoso added 3 commits October 2, 2024 10:44

Refs #21479: Include labeling check

dde7aad

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #21479: Keep 'Add label' job only in ubuntu workflow

f8cc87d

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #21479: Apply rev suggestions

c6ae1fd

Signed-off-by: eProsima <jesuspoderoso@eprosima.com>

JesusPoderoso force-pushed the feature/allow_external_CI branch from e924aaa to c6ae1fd Compare October 2, 2024 08:48

MiguelCompany approved these changes Oct 2, 2024

View reviewed changes

MiguelCompany merged commit 2d1e793 into master Oct 2, 2024
3 checks passed

MiguelCompany deleted the feature/allow_external_CI branch October 2, 2024 11:00

mergify bot mentioned this pull request Oct 2, 2024

[21479] Allow runing CI on external contributions (backport #5220) #5287

Merged

7 tasks

This was referenced Oct 2, 2024

[21479] Allow runing CI on external contributions (backport #5220) #5288

Merged

[21479] Allow runing CI on external contributions (backport #5220) #5289

Merged

mergify bot mentioned this pull request Oct 2, 2024

[21479] Allow runing CI on external contributions (backport #5220) #5290

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[21479] Allow runing CI on external contributions #5220

[21479] Allow runing CI on external contributions #5220

JesusPoderoso commented Sep 10, 2024 •

edited by MiguelCompany

Loading

MiguelCompany commented Sep 18, 2024

mergify bot commented Sep 18, 2024

MiguelCompany left a comment

MiguelCompany left a comment

MiguelCompany left a comment

MiguelCompany commented Oct 2, 2024

mergify bot commented Oct 2, 2024 •

edited

Loading

[21479] Allow runing CI on external contributions #5220

[21479] Allow runing CI on external contributions #5220

Conversation

JesusPoderoso commented Sep 10, 2024 • edited by MiguelCompany Loading

Description

Contributor Checklist

Reviewer Checklist

MiguelCompany commented Sep 18, 2024

mergify bot commented Sep 18, 2024

✅ Branch has been successfully rebased

MiguelCompany left a comment

Choose a reason for hiding this comment

MiguelCompany left a comment

Choose a reason for hiding this comment

MiguelCompany left a comment

Choose a reason for hiding this comment

MiguelCompany commented Oct 2, 2024

mergify bot commented Oct 2, 2024 • edited Loading

✅ Backports have been created

JesusPoderoso commented Sep 10, 2024 •

edited by MiguelCompany

Loading

mergify bot commented Oct 2, 2024 •

edited

Loading