-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21293] Fix destruction data-race on participant removal in intra-process #5034
Open
Mario-DL
wants to merge
11
commits into
master
Choose a base branch
from
hotfix/21293
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
October 3, 2024 11:07
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
October 3, 2024 11:10
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
October 3, 2024 20:08
Mario-DL
requested review from
richiprosima
and removed request for
richiprosima
October 3, 2024 21:40
Mario-DL
force-pushed
the
hotfix/21293
branch
from
October 14, 2024 16:40
b14868d
to
91ac4b7
Compare
Mario-DL
requested review from
MiguelCompany
and removed request for
MiguelCompany
October 14, 2024 16:41
Mario-DL
force-pushed
the
hotfix/21293
branch
from
October 14, 2024 22:15
91ac4b7
to
e8036c9
Compare
Mario-DL
requested review from
MiguelCompany
and removed request for
MiguelCompany
October 14, 2024 22:15
Mario-DL
force-pushed
the
hotfix/21293
branch
from
October 16, 2024 06:45
5bb09b7
to
49eaeb0
Compare
Mario-DL
requested review from
MiguelCompany
and removed request for
MiguelCompany
October 16, 2024 06:47
Mario-DL
commented
Oct 16, 2024
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…calReaderPointer> and properly calls local_actions_on_reader_removed() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
…when accessing local reader Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Mario-DL
force-pushed
the
hotfix/21293
branch
from
October 18, 2024 10:45
49eaeb0
to
8492570
Compare
Mario-DL
requested review from
MiguelCompany
and removed request for
MiguelCompany
October 18, 2024 10:46
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Mario-DL
requested review from
MiguelCompany
and removed request for
MiguelCompany
October 21, 2024 05:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a race issue happening in stressed intraprocess scenarios when
EDP's
writer intends to use the remote local reader pointer of an already removed participant. This happens because the participant hasn't received the other's one disposal yet (as it goes through transport).Some ci flaky tests have already been identified to be related with this issue.
The proposed solution introduces a new state in the Readers
LocalReaderViewStatus
in which the reader will notify that it is inactive as soon as it is destroyed and noone is using it.On the other side, the remote local writers using pointers to it, now holds a
LocalReaderPointer
which wraps the raw reader's pointer plus the view. An internal counter now accounts for the number of references.Thanks @MiguelCompany for helping with the final's solution design.
Note: the test may be launched with
--restest-until-fail 20
or so, in order to reproduce the issue. For a more frequent failure, review can launch thecolcon test
with thetaskset -c 0,1
prefix to make the test to stress more and make it fail more frequently.@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist